Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added basic, functional last.fm scrobble integration. #999

Closed
wants to merge 6 commits into from

Conversation

CosmicRaptor
Copy link
Member

As requested in #874 I have implemented basic scrobble to last.fm
I added a couple of text fields in the settings to enter your API Key and shared secret, along with proper input validations. There's some padding issue in the enable toggle and the save button that I couldn't figure out however
image

I also accidentally merged the 1.8.0 release in my fork please remove that 🙁

@CosmicRaptor
Copy link
Member Author

Some clarifications
The module waits for 20 seconds from the save button being pressed before calling the last.fm auth API to get a session key. It's only needed once.
But it assumes that within those 20 seconds your browser will open up and you will approve the connection request. There has to be a better way to do this hopefully.

@Feichtmeier
Copy link
Member

@CosmicRaptor first of all: great job! Thank you for following most of the architecture ideas

I think some things got wrong, even the tags are wrong I wonder what happened there
Could you make a new branch and apply your commit to it? and a new PR? sorry for this but there is a bunch of weird things in this branch I cant fix

@CosmicRaptor
Copy link
Member Author

Will do soon!

@Feichtmeier
Copy link
Member

thanks! make sure to pull a fresh main before you start a new branch

@CosmicRaptor CosmicRaptor closed this by deleting the head repository Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants