Draft: Enable webcam integration #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenvandine
reviewed
May 26, 2023
| #environment: | ||
| # DISABLE_WAYLAND: 'true' | ||
| environment: | ||
| DISABLE_WAYLAND: 'true' |
There was a problem hiding this comment.
It doesn't matter what DISABLE_WAYLAND is set to, but generally everywhere we use it we set it to 1. I'd rather do that for consistency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
The camera interface isn't autoconnected currently. Open the Ubuntu Settings app. In the left sidebar, choose Applications. Find the Contacts snap. Turn on the "Use your camera" permission.
Open the Contacts app. Click the + button to add a new contact. Click the person image. I'd expect the "Take a picture" button to be active but it wasn't in my testing.
As long as the button isn't active, there isn't any point in enabling this feature.
After that, if we don't get approval for the autoconnection, it might not be worth enabling the feature then either.