Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: adjust concept.RetrieveAttritionTable to produce rows in new order #74

Merged
merged 1 commit into from
Jun 29, 2023

Conversation

pieterlukasse
Copy link
Contributor

@pieterlukasse pieterlukasse commented Jun 28, 2023

Jira Ticket: VADC-614

Breaking Changes

  • adjust concept.RetrieveAttritionTable to produce rows in new order, where the order of the rows should follow the order of the concept ids and dichotomous pair variables found in the request

...where the order of the rows should follow the order of the concept ids
and dichotomous pair variables found in the request
@pieterlukasse pieterlukasse force-pushed the fix/order_of_variables_in_attrition_csv branch from 10572ae to 743c8aa Compare June 29, 2023 14:03
@pieterlukasse pieterlukasse marked this pull request as ready for review June 29, 2023 14:06
Copy link
Contributor

@m0nhawk m0nhawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. 👍

@pieterlukasse pieterlukasse merged commit 5d0409d into master Jun 29, 2023
5 checks passed
@pieterlukasse pieterlukasse deleted the fix/order_of_variables_in_attrition_csv branch June 29, 2023 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants