Feat/discovery load time spike #1579
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…with query params, css to gracefully hide them
…r, changed a boolean to an object
…s bar loading rate
…se a useEffect instead of combination of CSS transitions
…ss bar loading and dismissal more smooth
…will use mini version. Added functionality for loading spinners for Data Repository and Filters
…ed; removed disabling logic
src/Discovery/index.tsx
Outdated
| // to improve load time & usability | ||
| // Initially uses a smaller batch to load interface quickly | ||
| // Then a batch with all the studies | ||
| const [studiesBatchCount, setStudiesBatchCount] = useState(0); |
There was a problem hiding this comment.
Note: Update the variable name to "numberOfBatchesLoaded"
src/Discovery/index.tsx
Outdated
| @@ -167,16 +202,27 @@ const DiscoveryWithMDSBackend: React.FC<{ | |||
|
|
|||
| // indicate discovery tag is active even if we didn't click a button to get here | |||
| props.onDiscoveryPageActive(); | |||
| }, []); | |||
| }, [props, studiesBatchCount]); | |||
There was a problem hiding this comment.
Note: Update the variable name to "numberOfBatchesLoaded"
src/Discovery/index.tsx
Outdated
| useEffect(() => { | ||
| // If batch loading is Enabled, update the studiesBatchCount to enable calling of different batch sizes | ||
| // with different parameters | ||
| if (studiesBatchCount < expectedNumberOfTotalBatches) setStudiesBatchCount(studiesBatchCount + 1); |
There was a problem hiding this comment.
Note: Update the variable name to "numberOfBatchesLoaded"
…mberOfBatchesLoaded to improve clarity
|
Please find the ci env pod logs here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spike for Improve Discovery Page Loading UX
Ticket: https://ctds-planx.atlassian.net/browse/HP-1643
Before
Load time is approximately 5 seconds. Searches entered during loading do not update once loading is completed.
After
UX proposed with batch loading of 10 studies and then the rest. Initial load of first 10 studies takes around 200-300ms (95% improvement). UX shown includes a mini progress bar.
Instructions:
Pull local, then run in QA Dev.
Mini Progress Bar by Studies Count:
https://qa-heal.planx-pla.net/portal/dev.html?showMini