-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore/ccrypt usersync #1207
base: master
Are you sure you want to change the base?
Chore/ccrypt usersync #1207
Conversation
Please find the ci env pod logs here |
Please find the ci env pod logs here |
Please find the ci env pod logs here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good. Just a couple of questions, and will approve.
libxcrypt-compat-4.4.33 \ | ||
libpq-15.0 && \ | ||
echo "Installing RPM"; \ | ||
rpm -i https://ccrypt.sourceforge.net/download/1.11/ccrypt-1.11-1.x86_64.rpm; \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed we are using an x86 binary for ARM. Will this be emulated for ARM during use? Has any testing been done to confirm its functionality?
pyproject.toml
Outdated
@@ -22,7 +22,7 @@ cached_property = "^1.5.1" | |||
cdiserrors = "<2.0.0" | |||
cdislogging = "^1.0.0" | |||
cdispyutils = "^2.0.1" | |||
flask = ">=3.0.0" | |||
flask = "^2.2.3" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you clarify the reason for downgrading Flask?
Pull Request Test Coverage Report for Build 12477982982Details
💛 - Coveralls |
Please find the ci env pod logs here |
Please find the ci env pod logs here |
Link to JIRA ticket if there is one:
New Features
Breaking Changes
Bug Fixes
Improvements
Dependency updates
Deployment changes