Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/ccrypt usersync #1207

Draft
wants to merge 30 commits into
base: master
Choose a base branch
from
Draft

Chore/ccrypt usersync #1207

wants to merge 30 commits into from

Conversation

BinamB
Copy link
Contributor

@BinamB BinamB commented Dec 13, 2024

Link to JIRA ticket if there is one:

New Features

Breaking Changes

Bug Fixes

Improvements

Dependency updates

Deployment changes

Copy link

Please find the ci env pod logs here

Copy link

Please find the ci env pod logs here

Copy link

Please find the ci env pod logs here

Copy link
Contributor

@nss10 nss10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good. Just a couple of questions, and will approve.

libxcrypt-compat-4.4.33 \
libpq-15.0 && \
echo "Installing RPM"; \
rpm -i https://ccrypt.sourceforge.net/download/1.11/ccrypt-1.11-1.x86_64.rpm; \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed we are using an x86 binary for ARM. Will this be emulated for ARM during use? Has any testing been done to confirm its functionality?

pyproject.toml Outdated
@@ -22,7 +22,7 @@ cached_property = "^1.5.1"
cdiserrors = "<2.0.0"
cdislogging = "^1.0.0"
cdispyutils = "^2.0.1"
flask = ">=3.0.0"
flask = "^2.2.3"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you clarify the reason for downgrading Flask?

@coveralls
Copy link

coveralls commented Dec 20, 2024

Pull Request Test Coverage Report for Build 12477982982

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 178 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.06%) to 75.177%

Files with Coverage Reduction New Missed Lines %
jwt/keys.py 12 78.95%
init.py 22 90.16%
sync/sync_users.py 144 81.65%
Totals Coverage Status
Change from base Build 12356407492: -0.06%
Covered Lines: 7853
Relevant Lines: 10446

💛 - Coveralls

Copy link

Please find the ci env pod logs here

Copy link

Please find the ci env pod logs here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants