-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates prior to SQLAlchemy 2.0 upgrade #386
Open
martinburchell
wants to merge
32
commits into
master
Choose a base branch
from
sqlalchemy2-prep-work
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some of the code in the client API appears not to be reached so can't easily be tested
Removed in SQLAlchemy 2.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes for SQLAlchemy 2.0 that are compatible with 1.4 to reduce the number of changes in #385.
I've fixed anything that was broken in the Python tests with deprecation warnings enabled:
SQLALCHEMY_WARN_20=1 pytest -W error::sqlalchemy.exc.RemovedIn20Warning -W error::sqlalchemy.exc.MovedIn20Warning -W error::SADeprecationWarning
I've also fixed any other legacy calls to select() with the columns given in a single list argument. I've added tests where these cases weren't covered.
I've also changed the task test factories to number IDs from 1 instead of 0 and fixed a flaky webview test, which wrongly assumed object IDs would appear in a certain order.
I have not been able to test merge_db.py as I couldn't get it to work.
This error was with two recently created databases: