This repository has been archived by the owner on Apr 20, 2024. It is now read-only.
Release publishing flow #122
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abejgonzalez
reviewed
Aug 8, 2022
Comment on lines
+24
to
+25
| SONATYPE_PASSWORD: ${{ secrets.SONATYPE_PASSWORD }} | ||
| SONATYPE_USERNAME: ${{ secrets.SONATYPE_USERNAME }} |
There was a problem hiding this comment.
Who owns these? I'm concerned that these might be lost somewhere when one of the dev's leave.
| - run: sudo apt update && sudo apt install -y gnupg | ||
| - run: echo $PGP_SECRET | base64 --decode | gpg --batch --import | ||
| env: | ||
| PGP_SECRET: ${{ secrets.PGP_SECRET }} |
There was a problem hiding this comment.
Ditto (see the next msg)
| val defaultVersions = Map( | ||
| "chisel3" -> "3.5.1", | ||
| "chisel3" -> "3.5.3", | ||
| "chisel-iotesters" -> "2.5.1" |
There was a problem hiding this comment.
Nit: Should we just bump this to 2.5.4 anyways.
| @@ -3,7 +3,7 @@ Barstools | |||
|
|
|||
| --- | |||
|
|
|||
|  | |||
|  | |||
There was a problem hiding this comment.
If we are publishing to Sonatype, we should also update the readme to mention what needs to be added to peoples build.sbt files.
| @@ -1,3 +1,4 @@ | |||
| addSbtPlugin("com.eed3si9n" % "sbt-assembly" % "0.14.5") | |||
| addSbtPlugin("org.scalameta" % "sbt-scalafmt" % "2.4.3") | |||
| addSbtPlugin("net.virtual-void" % "sbt-dependency-graph" % "0.9.2") | |||
| addSbtPlugin("io.shiftleft" % "sbt-ci-release-early" % "2.0.32") | |||
There was a problem hiding this comment.
Not related to this PR. I wonder if there is another plugin/CI-flow that auto-bumps the SBT versions, scala versions, etc (and if that is really needed).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drafting tag-based publishing flow for barstools. Example release here (https://repo1.maven.org/maven2/edu/berkeley/cs/barstools_2.12/).