Skip to content
This repository has been archived by the owner on Apr 20, 2024. It is now read-only.

Fixed index offset in mask port mapping. #38

Merged
merged 2 commits into from
Feb 13, 2019
Merged

Conversation

jamesdunn
Copy link
Member

Fixing index offset in mask port mapping. This was originally done in #34 but did not make it to master.

Failure looked like

Exception in thread "main" firrtl.passes.PassExceptions:
firrtl.passes.CheckWidths$BitsWidthException: : [module tag_array_ext] High bit 9 in bits operator is larger than input width 8 in bits(R│[dunn@bwrcrdsl-1] /tools/B/dunn/hammer-workspace/project-template
W0_mask, 9, 9).

@edwardcwang
Copy link
Member

Do you have a unit test for this?

@jamesdunn
Copy link
Member Author

Do you have a unit test for this?

Not yet. It resolved the error I was seeing with the ST28 mems in EE194, but I can come up with a unit test.

@jwright6323
Copy link
Collaborator

@jamesdunn @edwardcwang I'm going to file a separate issue for the unit tests and merge this now.

@jwright6323 jwright6323 mentioned this pull request Feb 13, 2019
@jwright6323 jwright6323 merged commit 9d505d6 into master Feb 13, 2019
@edwardcwang edwardcwang deleted the james-macrocompiler branch February 13, 2019 23:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants