Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a GH action to auto run tests on commits.
@airabino There are a few tweaks to the modeling code for incoming inconsistency (handle/id). Could also just be misunderstanding. also some init stuff that i tweaked to get tests working, i think theses are safe but would like extra eyes in case i missed something obvious
having trouble understanding this issue from implementing the pypsa tests (https://github.com/ucdavis/good_model/actions/runs/13527537624/job/37801761757) - which are passing, but with some hacks. when we use realistic (positive) operating costs for generators, the model chooses to use wastage instead of generation to meet the load. i think it may be a constraint thing? where wastage is this free source of energy?
for other PyPSA based tests, i hacked a negative wastage costs to encourage generation, or positive wastage costs to discourage wastage, which both work but yeah are hacks
i think we may need to do some or all of the following
or am i just not understanding something fundamental?