Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testing and docs updates #2

Open
wants to merge 8 commits into
base: 1.0.1
Choose a base branch
from
Open

Conversation

nmstone
Copy link
Collaborator

@nmstone nmstone commented Feb 18, 2025

Added a GH action to auto run tests on commits.

@airabino There are a few tweaks to the modeling code for incoming inconsistency (handle/id). Could also just be misunderstanding. also some init stuff that i tweaked to get tests working, i think theses are safe but would like extra eyes in case i missed something obvious

having trouble understanding this issue from implementing the pypsa tests (https://github.com/ucdavis/good_model/actions/runs/13527537624/job/37801761757) - which are passing, but with some hacks. when we use realistic (positive) operating costs for generators, the model chooses to use wastage instead of generation to meet the load. i think it may be a constraint thing? where wastage is this free source of energy?

for other PyPSA based tests, i hacked a negative wastage costs to encourage generation, or positive wastage costs to discourage wastage, which both work but yeah are hacks

i think we may need to do some or all of the following

  • have zero or small positive wastage cost
  • energy balance constraints that ensure wastage only occurs when there's excess generation
  • have a high shortfall cost to make unserved energy expensive

or am i just not understanding something fundamental?

@nmstone nmstone requested a review from airabino February 25, 2025 17:48
@nmstone nmstone changed the title WIP: testing and docs updates testing and docs updates Feb 25, 2025
@nmstone nmstone marked this pull request as ready for review February 25, 2025 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant