Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search the order id in the table #418

Merged
merged 1 commit into from
Aug 2, 2024
Merged

Search the order id in the table #418

merged 1 commit into from
Aug 2, 2024

Conversation

jSylvestre
Copy link
Member

Issue #413

Copy link
Contributor

@sprucely sprucely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. I don't know if case sensitivity matters for ID. If so, maybe do something like...
return row.original.id.toString().toLower().includes(filterValue.toLower());

@jSylvestre
Copy link
Member Author

Looks fine. I don't know if case sensitivity matters for ID. If so, maybe do something like... return row.original.id.toString().toLower().includes(filterValue.toLower());

Just an int, so no.
Could potentially have it do an exact match, but I figured this would be a little more flexible. No idea why it needed this though

@jSylvestre jSylvestre merged commit be450a5 into main Aug 2, 2024
3 checks passed
@jSylvestre jSylvestre deleted the JCS/FixOrderIdSearch branch August 2, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants