Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue/53 - My Widgets page accessiblility #1233

Closed
wants to merge 7 commits into from
Closed

issue/53 - My Widgets page accessiblility #1233

wants to merge 7 commits into from

Conversation

weining-li
Copy link
Contributor

Added tabindex and ng-keypress attributes to elements on My Widgets page that weren't reachable by tabbing.

ucfopen/Materia-Server-Client-Assets#53

@iturgeon iturgeon added this to the Ramuh (Dev6) milestone Jul 9, 2019
Copy link
Contributor

@FrenjaminBanklin FrenjaminBanklin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a start, but there's more that needs doing here. The main two issues that still remain are:

  1. When tabbing to any element that opens a modal dialog, then activating it, the focus remains on the element that activated the dialog instead of switching to the dialog itself. You can use an Angular directive to automatically apply focus to an element, and we've used such directives in a few widgets to date. See this example in Enigma, and how you'd use it.

  2. There's no easy way to escape the list of widgets. Tab will move between widgets in the list and any keypress (see below about whether we should be strictly checking for the Enter key instead) will select that widget - but then the user is still stuck in the list of widgets. They'd have to keep tabbing through the list to get to the rest of the page. There are a few ways we could deal with this - either by overriding the Tab key and using arrow keys or some other means of navigating the widget list, automatically moving focus out of the widget list when a widget is selected and moving back to that same position in the list when the list receives focus, using some other key combination to enter or exit the widget list, etc.

Also, it might be preferable to use our ng-enter directive instead of ng-keypress wherever something is meant to be activated based on keyboard input. We might need to discuss whether that's necessary or if any key input will suffice.

@weining-li weining-li closed this Jul 26, 2019
@weining-li weining-li reopened this Jul 26, 2019
Copy link
Contributor

@FrenjaminBanklin FrenjaminBanklin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is closer, looks like all of the access settings are still only reacting to clicks, though.

@FrenjaminBanklin FrenjaminBanklin changed the base branch from master to dev/7-alexander December 3, 2019 15:50
@clpetersonucf clpetersonucf reopened this Jul 10, 2020
@clpetersonucf clpetersonucf changed the base branch from dev/7-alexander to dev/8-knights-of-the-round July 10, 2020 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants