Issue/settings dialog

[cayb0rg]

Fixes #1512

• Hides embedded only option for students and student made widgets and increases dialog's max-height

Fixes #1504

• Updates settings dialog view and edit permissions for grandfathered-in users

Additional

• Added error message for when you try to remove guest access from a student-made widget in instance manager
• Adds 'owner' tag to collaborator dialog

Continuation of #1516

[clpetersonucf]

Great work. I left one request below based on displaying scores, but I'd also like to see some level of responsiveness added to the settings dialog. Currently, if a user is interacting with the dialog with a lower resolution display, the bottom of the dialog is cut off and prevents them from selecting the Save and Cancel options at the bottom.

[cayb0rg]

I overlooked the fact that students should still be able to view guest scores, thank you! I added an is_student check to play_logs_get to exclude information such as user ID, first name, last name, and username from the results. The front-end will combine these into a single "Guests" score. It will still display the number of students.

I've also updated the setting dialog to be more responsive. Still working on the attempts for mobile.

[clpetersonucf]

Some small things here and there that caught my eye.

Additionally, there appear to be some issues with rendering the settings dialog related to the responsive styles you added, at least on my end:

[cayb0rg]

Thanks for spotting these!

Additionally, there appear to be some issues with rendering the settings dialog related to the responsive styles you added, at least on my end:

I couldn't replicate this issue (which I assume is the date picker wrapping even though there is room for it). Could you possibly specify the browser, screen width, and/or zoom level?

[clpetersonucf]

I couldn't replicate this issue (which I assume is the date picker wrapping even though there is room for it). Could you possibly specify the browser, screen width, and/or zoom level?

Firefox, 100% zoom, 1792px. I don't recall encountering this issue previously, but it definitely appears related to the addition of flex-wrap on line 301 of the settings-dialog stylesheet.

[clpetersonucf]

Approved. Really great work here: your solution to score display when a user becomes a student is inspired. It's non-destructive, still gives user score access, but decontextualizes the scores until/unless the student role is replaced.

Well done, I think this is good to go.