Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improves play.auth string check in user admin panel #1544

Merged
merged 1 commit into from
Jan 4, 2024
Merged

improves play.auth string check in user admin panel #1544

merged 1 commit into from
Jan 4, 2024

Conversation

clpetersonucf
Copy link
Member

Resolves #1543

FrenjaminBanklin
FrenjaminBanklin approved these changes Jan 3, 2024
View reviewed changes
Copy link
Contributor

@FrenjaminBanklin FrenjaminBanklin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checking the type is probably safer than casting play.auth to a string in all cases.

Looks good to me.

@clpetersonucf clpetersonucf merged commit 9978e88 into ucfopen:dev/10.1.0 Jan 4, 2024
2 checks passed
@clpetersonucf clpetersonucf deleted the issue/1543-user-admin-auth-type-check-fix branch January 4, 2024 15:15
This was referenced Jan 4, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FrenjaminBanklin FrenjaminBanklin FrenjaminBanklin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@clpetersonucf @FrenjaminBanklin