Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes to My Widgets score summary user search #1554

Merged
merged 3 commits into from
Jan 9, 2024
Merged

Fixes to My Widgets score summary user search #1554

merged 3 commits into from
Jan 9, 2024

Conversation

clpetersonucf
Copy link
Member

Resolves #1550

  • Implements our own custom useDebounce hook to un-brick the student search feature
  • Adds conditionally rendered "No users found" state when user search returns an empty set
  • Two small unrelated fixes while I was digging through associated files: a comment typo and a duplicate, unused class attribute

cayb0rg
cayb0rg approved these changes Jan 9, 2024
View reviewed changes
Copy link
Contributor

@cayb0rg cayb0rg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done!

This is irrelevant to the issue, but while we're looking at the individual scores, we could remove the overlap here:
image

@clpetersonucf clpetersonucf merged commit f38dd85 into ucfopen:dev/10.1.0 Jan 9, 2024
2 checks passed
@clpetersonucf clpetersonucf deleted the issue/1550-fix-student-search-my-widgets branch January 9, 2024 15:35
@clpetersonucf clpetersonucf mentioned this pull request Jan 9, 2024
Merged
@clpetersonucf clpetersonucf mentioned this pull request Mar 27, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cayb0rg cayb0rg cayb0rg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@clpetersonucf @cayb0rg