Re-implements LTI-restricted logins #1631
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to Materia v10, setting the
BOOL_LTI_RESTRICT_LOGINS_TO_LAUNCHESvariable totruewould hide the Login link from the header and yield a 404 when attempting to visit/login. That behavior regressed in v10, with the config having no effect on restricting logins.Instead of hiding the login link completely, this change causes login views (
/loginas well as widget embed previews) to instead indicate that auth is restricted to the LMS. The?directlogin=1bypass remains in place.