Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dev/1.3.0 #40

Merged
merged 22 commits into from
Apr 24, 2024
Merged

Dev/1.3.0 #40

merged 22 commits into from
Apr 24, 2024

Conversation

clpetersonucf
Copy link
Member

cayb0rg and others added 22 commits February 21, 2023 14:12
@cayb0rg
Removes unnecessary call to get_qset from score_module and references…
594bc1c 
… to qset in scorescreen.js
@cayb0rg
Removes comment
3d55741
@dmols
Added question bank functionality to creator and player side
5614186
@dmols
Polished the functionality and added styling
a58620a
@dmols
Replaced question dialog function calls with ng-click attributes
a0166e7
@dmols
WIP: making enableQuestionBank initially false
4cef684
@dmols
Fixed questionBankVal initial value and added input safeguards
3c98421
@dmols
Removed break statements and added visual padding in the dialog
d28bfc9
@dmols
Added lots of css changes to dialog and changed functionality
088a39d
@dmols
visual improvements for the dialog and semantic html changes
ff0c079
@dmols
Minor css changes
1d8e362
@dmols
Added tooltip for QB functionality and tweaked some css
4bf05a0
@clpetersonucf
Comprehensive update to MWDK 3.x
0cc8a47
@clpetersonucf
Removes unnecessary dependencies. Updates hard-coded angularjs import…
beb9ba0 
…s to 1.8.3
@clpetersonucf
Merge pull request #38 from clpetersonucf/feature/mwdk-upgrade
a66d6cb 
Updates to MWDK 3.x
@clpetersonucf
Merge branch 'dev/1.3.0' into implementing_questionBank
692a717
@clpetersonucf
Merge pull request #36 from dmols/implementing_questionBank
d140a1a 
Added Question Bank Functionality
@clpetersonucf
Header style overhaul. Replaces reliance on floats and absolute posit…
e449060 
…ioning with flexbox.
@clpetersonucf
Tweaks to qb dialog styling
710d428
@clpetersonucf
Merge pull request #39 from clpetersonucf/polish-for-1.3.0
28afeec 
Polish for 1.3.0
@clpetersonucf
Merge pull request #31 from ucfopen/issue/30-scorescreen-qset
1adb8cb 
Issue/30 scorescreen qset
@clpetersonucf
Small tweak to ensure creator tutorial hides in a timely manner
0e4804c
FrenjaminBanklin
FrenjaminBanklin approved these changes Apr 24, 2024
View reviewed changes
Copy link
Contributor

@FrenjaminBanklin FrenjaminBanklin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question bank functionality seems to work well, custom score screen seems to work well, old widgets seem to work well.

Looks good to me.

@clpetersonucf clpetersonucf merged commit a8aaf19 into master Apr 24, 2024
2 checks passed
@clpetersonucf clpetersonucf deleted the dev/1.3.0 branch April 24, 2024 21:13
@cayb0rg
Copy link
Contributor

cayb0rg commented Apr 25, 2024

This has already been merged, but in the future we should update the Creator Guide to include the question bank feature. I also did not catch any bugs on QA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FrenjaminBanklin FrenjaminBanklin FrenjaminBanklin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@clpetersonucf @cayb0rg @FrenjaminBanklin @dmols