-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uses master branch Pymer4 instead of dev branch #7
Conversation
The dev branch was two years old and had dependencies that are not needed for the master branch. We now specify a branch off the master with ranef_cond_std merged in.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any reason you didn't to git merge master
from the get_ranef_cond_std
branch? If not, do that instead of creating a brand new branch (and thus making this pull request unnecessary).
@AndrewRidden-Harper will you see if Jake's suggestion works? |
Jake's suggestion worked so there's no need to create a new branch |
The reason for creating the new branch was due to the fact that for the main pymer4 repo PRs are meant to created for the |
@claudio525 @lispandfound @sungeunbae Claudio, that's a good point. I didn't consider the fact that this would affect the pull request to the main Pymer4 repo. Perhaps we should just reset the get_ranef_std_dev branch back to a pre-merge commit and go back to the original plan of using a new branch off their master? |
@AndrewRidden-Harper No just leave as is and wait for ejolly to respond |
This pull request just changes the branch of our Pymer4 repo listed in the requirements file.
This new branch came off the main Pymer4 branch. The changes for getting the random effects' conditional standard deviations were merged in. This was needed because the Pymer4 dev branch was two years old and had dependencies that are not needed for the main branch.