Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CTP-1685 add unfreeze function to lifecycle block #17

Merged
merged 4 commits into from
Dec 3, 2024
Merged

Conversation

aydevworks
Copy link
Contributor

Deployed on 44-clc.

@aydevworks aydevworks requested a review from aspark21 November 17, 2024 00:59
@aspark21
Copy link
Collaborator

Code reviewed & tested.

When unfreezing, this gives 1 day before the course is frozen again.
I don't see anywhere where this is defined though?

@aydevworks
Copy link
Contributor Author

Code reviewed & tested.

When unfreezing, this gives 1 day before the course is frozen again. I don't see anywhere where this is defined though?

Yes, I forgot to disable the auto context freezing for the course after unfreeze, so it will be frozen again in the next day when the scheduled task runs.

@aspark21
Copy link
Collaborator

I think 1 day was fine but maybe we can have a pop up warning them it will refreeze unless they go and change settings in the block

@aydevworks
Copy link
Contributor Author

I think 1 day was fine but maybe we can have a pop up warning them it will refreeze unless they go and change settings in the block

Updated and deployed to 44-clc.

@aspark21
Copy link
Collaborator

aspark21 commented Dec 1, 2024

Tested and code reviewed. Have made some minor changes to the language strings for clarity.

Once the hardcoded words are moved to language strings, this can be merged

@aydevworks
Copy link
Contributor Author

Tested and code reviewed. Have made some minor changes to the language strings for clarity.

Once the hardcoded words are moved to language strings, this can be merged

Updated, thanks!

@aspark21 aspark21 merged commit d2abf39 into main Dec 3, 2024
13 checks passed
@aspark21 aspark21 deleted the CTP-1685-nojs branch December 3, 2024 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants