CTP-3558 coding std PR comments

ucl-isd · Aug 19, 2024 · fa1db75 · fa1db75
1 parent 85758db
commit fa1db75
Show file tree

Hide file tree

Showing 7 changed files with 5 additions and 9 deletions.
diff --git a/classes/file_importer.php b/classes/file_importer.php
@@ -34,8 +34,8 @@ public function extract_zip_file($filename, $contextid) {
 
         global $USER;
 
-        // Raise_memory_limit(MEMORY_EXTRA);
-        //@set_time_limit(ASSIGNFEEDBACK_FILE_MAXFILEUNZIPTIME);
+        // raise_memory_limit(MEMORY_EXTRA);
+        // @set_time_limit(ASSIGNFEEDBACK_FILE_MAXFILEUNZIPTIME);
 
         $packer = get_file_packer('application/zip');
 

diff --git a/classes/models/sample_set_rule.php b/classes/models/sample_set_rule.php
@@ -106,7 +106,7 @@ public function __construct($coursework) {
 
         $this->coursework = $coursework;
 
-        // Parent::__construct($dbrecord);
+        // parent::__construct($dbrecord);
 
         // We cannot set this from outside if we are making a new one.
         if (!isset($this->ruleorder)) {

diff --git a/classes/renderers/coursework_renderer.php b/classes/renderers/coursework_renderer.php
@@ -1 +0,0 @@
-

diff --git a/classes/renderers/submission_renderer.php b/classes/renderers/submission_renderer.php
@@ -1 +0,0 @@
-

diff --git a/lang/en/coursework.php b/lang/en/coursework.php
@@ -855,7 +855,7 @@
 $string['moderationenabled_help'] = 'Allow a moderator to mark a subset of the submissions. A moderator\'s grade becomes the final grade for any submission they mark.';
 $string['grade_help'] = 'Select the grade scale on which this coursework will be marked';
 $string['anonymitydescription'] = '<p>Blind marking - You will not see students names';
-$string['allocationenabled_help'] = 'Restrict which assessors will mark which submission,';
+$string['allocationenabled_help'] = 'Restrict which assessors will mark which submission';
 
 $string['oneweekoption'] = '1 week';
 $string['twoweeksoption'] = '2 weeks';

diff --git a/tests/classes/export/csv_test.php b/tests/classes/export/csv_test.php
@@ -40,7 +40,7 @@ class csv_test extends advanced_testcase {
 
     use mod_coursework\test_helpers\factory_mixin;
 
-    public function setUp() {
+    public function setUp():void {
 
         $this->resetAfterTest();
 

diff --git a/view.php b/view.php
@@ -416,8 +416,6 @@
 $PAGE->set_title($coursework->name);
 $PAGE->set_heading($course->shortname);
 
-// $PAGE->set_button($OUTPUT->update_module_button($course_module->id, 'coursework')); // deprecated from 3.2 (MDL-53765 core)
-
 // Auto publish after the deadline
 if ($coursework->has_individual_autorelease_feedback_enabled() &&
     $coursework->individual_feedback_deadline_has_passed() &&