Convert ViewportAwareButton JS files to TypeScript #1094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy request for sleepy-franklin-7a3e4c pending review.Visit the deploys page to approve it
|
mizlan
requested changes
Oct 31, 2023
|
Oh also: didn't notice that you renamed the test file as well. Could you please revert that change for now (undo the renaming?) I'm not sure if you changed any of the contents of the file but let's not touch that for now, it might get finicky. |
mizlan
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renamed ViewportAwareButton and ViewportAwareButtonTest to from .js to .tsx and converted function interface to Typescript