Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

convert radio.js to tsx #1102

Merged
merged 2 commits into from
Nov 29, 2023
Merged

convert radio.js to tsx #1102

merged 2 commits into from
Nov 29, 2023

Conversation

ChancellorO
Copy link
Contributor

No description provided.

@netlify Netlify
Copy link

netlify bot commented Nov 11, 2023 •
edited
Loading

👷 Deploy request for sleepy-franklin-7a3e4c pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit a4cb6be

mizlan
mizlan requested changes Nov 11, 2023
View reviewed changes
Copy link
Member

@mizlan mizlan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I run your code locally, I get a problem where this.props is not defined.

src/components/common/Radio.tsx Outdated Show resolved Hide resolved
src/components/common/Radio.tsx Outdated Show resolved Hide resolved
mizlan
mizlan requested changes Nov 16, 2023
View reviewed changes
Copy link
Member

@mizlan mizlan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please address all the destructuring-props-assignment lint errors?

@mizlan mizlan merged commit a6c172d into uclaacm:master Nov 29, 2023
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mizlan mizlan mizlan requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ChancellorO @mizlan