Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Navigation bar update #157

Merged
merged 14 commits into from
Apr 27, 2024
Merged

Navigation bar update #157

merged 14 commits into from
Apr 27, 2024

Conversation

AudreyW05
Copy link
Contributor

@AudreyW05 AudreyW05 commented Apr 27, 2024 •
edited
Loading

Changes

Old open source nav bar

Screenshot 2024-04-26 at 11 38 31 AM

ACM Website nav bar

Screenshot 2024-04-26 at 11 38 37 AM
  • Now the ACM logo matches the one of the main website and directs the user to the landing of the open source page, the nav bar has an extra button that leads the user to the main ACM website, the buttons have the same styling as the ACM Website and a hamburger menu appears in mobile view.
Screenshot 2024-04-26 at 11 45 42 AM

Code

  • copied the css styling for the nav bar in acm website to the global css file in open source

@AudreyW05
Changes:
79aacc5 
- Changed the photo of the logo in the nav bar to be the same as the main website
- Linked the main ACM website to the logo
- Deleted the image file of the original logo
@AudreyW05
Changes:
f6f5854 
- Modified Navbar height to match ACM page
- Changed Navbar position to fixed
- Modified text font of links to match ACM page
- Made links turn ACM blue on hover to match ACM page
@AudreyW05
Changes:
9d429dc 
- Fix spacing between GITHUB link and contribute link
@AudreyW05
Changes:
52add6e 
- Modify font size of the links
@AudreyW05
Changes:
41c8335 
- Add margin to the top of the body to account for the nav bar
@AudreyW05
Changes:
464e28e 
- Made logo link back to the open source main page
- Added a acm website link in the nav bar
@AudreyW05
Changes
ff78572 
- Modified the css file for navbar to match the acm page
- Edited the hamburger so that it will show
@AudreyW05
Change Github button:
375243c 
- add transition on hover
- add a different styling for this github button than other buttons
- add border
@AudreyW05
Fix box-shadow issue:
8f39d27 
- issue: when a button is clicked there was a blue outline
- changes: declared box shadow as none for buttons
@AudreyW05
fix blue outline of hamburger menu
7715b38 
- added box-shadow: none; to the hamburger styling
snigdha-kansal
snigdha-kansal requested changes Apr 27, 2024
View reviewed changes
Copy link
Contributor

@snigdha-kansal snigdha-kansal left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, Audrey!

Few things that I noticed:

  1. There is a lot of spacing between the buttons for acm website, projects, contribute, and github on the nav bar. Would be great if we can reduce it.
  2. The blue border appears around the hamburger icon when it is clicked. Can we remove that using another
    box-shadow: none ?
  3. The button for GitHub is a bit too rounded right now. I think it'd help to reduce the roundness. You can use the button that appears on clicking the hamburger icon as reference for this.

Also, can you update the pull request description to link the issue it resolves? Thanks!

I think once we have these down, we can merge this branch!

@AudreyW05
fix spacing between buttons
9855655 
- make spacing smaller
- make spacing between github button and other buttons more consistent
@AudreyW05
Merge branch 'navigation-bar-update' of https://github.com/uclaacm/op…
01a664f 
…ensource into navigation-bar-update
@AudreyW05
make github button less rounded
5faf02e
snigdha-kansal
snigdha-kansal approved these changes Apr 27, 2024
View reviewed changes
Copy link
Contributor

@snigdha-kansal snigdha-kansal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@snigdha-kansal snigdha-kansal merged commit e89c266 into main Apr 27, 2024
6 checks passed
@snigdha-kansal snigdha-kansal deleted the navigation-bar-update branch April 27, 2024 22:49
This was referenced Apr 28, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snigdha-kansal snigdha-kansal snigdha-kansal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AudreyW05 @snigdha-kansal