Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Landing page changes #172

Merged
merged 5 commits into from
May 31, 2024
Merged

Landing page changes #172

merged 5 commits into from
May 31, 2024

Conversation

AudreyW05
Copy link
Contributor

Changes

AudreyW05 added 2 commits May 13, 2024 16:47
@AudreyW05
Changes:
0f8f6ca 
- landing page title
- landing page description
- project page title
@AudreyW05
Changes:
542e433 
- modify projects page description
@AudreyW05 AudreyW05 requested a review from snigdha-kansal May 30, 2024 00:10
snigdha-kansal
snigdha-kansal reviewed May 30, 2024
View reviewed changes
pages/projects.tsx Outdated
<h1>
projects
</h1>
<h1>check out current UCLA open source projects</h1>
Copy link
Contributor

@snigdha-kansal snigdha-kansal May 30, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

I think we want to change the description on the card link under Projects on the landing page to "Check out current UCLA open source projects!" and not the title of the projects page.

AudreyW05 added 3 commits May 29, 2024 19:16
@AudreyW05
Changes:
7ec5704 
- Change project title back to project
- Change project card content
- Change learning card to end with an exclamation mark
@AudreyW05
Merge branch 'main' into landing-page-changes
ec7d1d1
@AudreyW05
Changes:
008bcfa 
- Make project card styling align with other cards
snigdha-kansal
snigdha-kansal approved these changes May 31, 2024
View reviewed changes
Copy link
Contributor

@snigdha-kansal snigdha-kansal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Nice work, Audrey 💯

@snigdha-kansal snigdha-kansal merged commit e91df15 into main May 31, 2024
6 checks passed
@snigdha-kansal snigdha-kansal deleted the landing-page-changes branch May 31, 2024 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snigdha-kansal snigdha-kansal snigdha-kansal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AudreyW05 @snigdha-kansal