-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use octokit + public repository API to generate projects data #57
Merged
Merged
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
b42e8d1
refactored projects to use github api instead
matthewcn56 3501bcb
fixed autoformatting and removed extraneous updated_at
matthewcn56 58ce766
fixed linting runs
matthewcn56 5bbbd56
addressed jest issues
matthewcn56 fe675b6
added iframe for img
matthewcn56 5979511
removed iframe in favor of committee logos
matthewcn56 9205058
added color badges using github data
matthewcn56 05f9f7d
jest snapshot updated
matthewcn56 6fe0be6
octokit pagination for all repos
matthewcn56 da4be01
Addressed Changes
matthewcn56 e4a2068
updated jest snapshot
matthewcn56 542a925
addressed merge conflicts and properly types github events with octokit
matthewcn56 a4e7453
attempted to fix jest issues
matthewcn56 637cc09
Merge branch 'main' into api-for-projects
mattxwang deddd8b
fixes lint error
mattxwang c9824b6
removes snapshot test for homepage
mattxwang 33b8781
fixed layout and image
matthewcn56 b415339
removed extraneous div
matthewcn56 f97abfa
fixed row gap
matthewcn56 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
{ | ||
"singleQuote": true, | ||
"trailingComma": "all" | ||
} | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if I'm missing something, but prettier is not in this repo / in this branch. Did you mean to add prettier?
If so, can we try to keep the formatting consistent with what already exists? i.e., minimizing the number of changes introduced in this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This overrides the default prettier configs so that developers can use it and it can still stay consistent with what already exists. While it's not necessary, I think it can help remove some of the formatting conflicts that arose in other PRs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gotcha; to separate concerns, could we move this to another PR where we also add
prettier
? I think we removed a while back in another PR (#3 and #4), but it's probably a good idea to reintroduce.