Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Demo Page to reflect Figma. #328

Merged
merged 2 commits into from
Oct 19, 2023
Merged

Update Demo Page to reflect Figma. #328

merged 2 commits into from
Oct 19, 2023

Conversation

lawtlee
Copy link
Contributor

@lawtlee lawtlee commented Oct 19, 2023

WARNING: The ladders are fixed size, and the margins are fixed right now, so if you do switch screen size there will be issues with the margining.

Completed the Demo Page

Summary

Closes #302

  • fixed some styling on several components
    • Demo.scss, Hintbox.scss, ShelfAddress.scss

Screenshots

WARNING: The ladders are fixed size, and the margins are fixed
right now, so if you do switch screen size there will be issues with the margining.
@lawtlee lawtlee requested a review from Dankco October 19, 2023 17:38
@netlify
Copy link

netlify bot commented Oct 19, 2023

Deploy Preview for parcel-pointers ready!

Name Link
🔨 Latest commit 563e9a0
🔍 Latest deploy log https://app.netlify.com/sites/parcel-pointers/deploys/65319fbc1c812e000851a023
😎 Deploy Preview https://deploy-preview-328--parcel-pointers.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@Dankco Dankco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! I can really see it starting to come together!

@Dankco Dankco merged commit 44a6fa6 into main Oct 19, 2023
5 checks passed
@Dankco Dankco deleted the 302_DemoPage branch October 19, 2023 21:33
@Dankco
Copy link
Contributor

Dankco commented Oct 19, 2023

There is still more to do here though. I will be ticketing the rest of the changes needed, this ticket was honestly pretty important to setting up finishing this page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Minor Update: Setup the Demo Page for the final version
2 participants