Added animation to FillArrow #335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added the animation of left to right in FillArrow. The logic can be copied over to other .scss files if you want to animate the background.
✅ Deploy Preview for parcel-pointers ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Dankco
reviewed
Oct 22, 2023
src/styles/FillArrow.scss
Outdated
|
|
||
| .reset { | ||
| position: relative; | ||
| // left: 5rem; |
src/components/FillArrow.tsx
Outdated
| return ( | ||
| <> | ||
| <div ref={ref} className="overall-container"> | ||
| <VscDebugRestart className="reset" onClick={() => setAnimate(false)} /> |
There was a problem hiding this comment.
Let's remove this button because its kind of buggy and doesn't really feel good to click to see the animation again. Let's just have the animation loop automatically instead, like a GIF.
There was a problem hiding this comment.
can't seem to animate it like a gif but i removed the button. Probably will look into it at another date
There was a problem hiding this comment.
Ok, I can take a look as well, but I will ticket.
Removed a Button
Dankco
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the animation of left to right in
FillArrow. The logic can be copied over to
other .scss files if you want to animate the background.
Summary
Closes #163
of the div but it changes it in the entirety. Can i use this code to achieve my goal?
@Keyframes example {
from {background-color: red;}
to {background-color: yellow;}
}
Screenshots
Screen.Recording.2023-10-20.at.12.09.21.AM.mov