100 feature call the congratulations page #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e first exercise, but there is a problem when it gets called after other exercises since the lessonside gets called previously. It is also not reactive to the page size.
1 task
✅ Deploy Preview for pen-pals ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
SanjnaT41756
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added the feature for the congratulations page to be called at the end of the exercises. Also fixed some CSS styling issues.
Closes #100
Added a conditional within App.tsx that renders the LessonSide if the exerciseCount is less than the max exercise (6 total exercises, so it is 7)
Also changed the call to CongratsPage in exerciseside to be more consistent with the rest.
No new dependencies needed.
Test Plan
This was tested by going through the current available exercises to see if the congrats page would appear at the end of them, and without the lesson side on the side.