Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Add image picker to edit profile #140

Closed
wants to merge 1 commit into from
Closed

[WIP] Add image picker to edit profile #140

wants to merge 1 commit into from

Conversation

pluscubed
Copy link
Member

@pluscubed pluscubed commented Jun 2, 2019 •
edited
Loading

Resolves #137

also fix feedback & settings :D

Copied code from create profile VC, and it's functionally complete.

TODO:

  • the image is downloaded when opening the edit profile VC, instead of using the one already downloaded in the profile VC
  • need to prevent going back when uploading the image

@HirdayGupta HirdayGupta self-requested a review November 22, 2019 01:09
HirdayGupta
HirdayGupta approved these changes Nov 22, 2019
View reviewed changes
Copy link
Member

@HirdayGupta HirdayGupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO:
the image is downloaded when opening the edit profile VC, instead of using the one already downloaded in the profile VC
need to prevent going back when uploading the image

These TODOs are fine - no need to fix them.
Change looks good otherwise!

@HirdayGupta HirdayGupta mentioned this pull request Nov 23, 2019
Merged
@HirdayGupta
Copy link
Member

Merged in #146

@HirdayGupta HirdayGupta deleted the edit-profile-image branch November 23, 2019 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HirdayGupta HirdayGupta HirdayGupta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add changing profile picture
2 participants
@pluscubed @HirdayGupta