Aholmes polish web and db #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ibute to the mono-repo.
This was primarily caused by `TYPE_CHECKING` being set to `True`, which caused cyclic imports in pydantic.
Blueprint docs are not rendered for OpenAPI applications, and vice versa. Also added docs for OpenAPI applications.
Also fixed some errors in values in the config.
Also added the documentation to scaffolded applications. Also fixed some errors in values in the config.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #...
Checklist
Formatting
I have read the code review guidelines and the code review best practice on GitHub check-list.
The name of the branch is meaningful and well formatted following the standards, using [AD_username (or 5 letters of AD if AD is too long)-[brief_description_of_branch].
I have set up or verified the branch protection rule following the github standards before opening this pull request.
File Updates
I have ensured that the version number update follows the semantic versioning standards.
I have updated the version number/requirements and added my name to the author list in the
setup.cfg.I have updated the version number/feature changes in the
README.md.I have updated the version number and added my name to the contributors list in the
metadata.yaml.I have added the changes included in this pull request to the
CHANGELOG.mdunder the next release version or unreleased, and updated the date.CHANGELOG.mdin the release.Testing
I have added unit tests for the new feature(s).
I modified the integration test(s) to include the new feature.
All existing tests for [this tool] passed locally and/or on the cluster.