Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Makefile to scaffolded applications #136

Merged
merged 7 commits into from
Oct 17, 2024

Conversation

aholmes
Copy link
Member

@aholmes aholmes commented Oct 14, 2024

This change includes a template file to add a Makefile to scaffolded applications. There are also documentation updates to support this change.

@aholmes aholmes requested a review from a team as a code owner October 14, 2024 20:56
Base automatically changed from aholmes-fix-scaffold-type-error to main October 15, 2024 17:04
Copy link

@dan-knight dan-knight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Would it be too much to add an E2E test for this Makefile in a scaffolded application created for testing?

@aholmes aholmes merged commit 447018c into main Oct 17, 2024
12 checks passed
@aholmes aholmes deleted the aholmes-add-makefile-to-scaffolder branch October 17, 2024 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants