SSO, test additions, database work, ASGI middleware, and more #58

aholmes · 2024-05-03T23:59:04Z

This massive PR contains the work required to finish the CAP migration. That includes components for SSO, database migrations, ASGI, SSM, users/roles, sessions, integration between Flask and Connexion, various middlewares, and so on.

Dan and I will go over this PR in person and review the dark corners.

- Also reorganized Feature Flag components to fit the structure of the Identity tables.

…using it.

- Also removed old comment.

…zation.

…e openapi_client test fixture.

src/identity/BL_Python/identity/SAML2/__init__.py

… Makefile.

dan-knight · 2024-05-13T20:39:48Z

Based on our discussion/review in person this looks good to me. A few notes:

I like the move to Config classes. We already see benefits when setting up the test environment(s).
A lot of this functionality is consistent with CAP (if not directly lifted from CAP).
We may revisit feature flags in the future. The tests look good to me, but we're not yet using the feature as extensively as we likely will in the future. So far, we're focusing on storing feature flags in the database. I wonder if we might need to extend this in future to allow other methods of handling feature configuration. Way outside the scope of this PR.

…g `.ONESHELL`.

dan-knight

Approving with Makefile updates for MacOS. make dev runs correctly for me, creating the virtual environment in the correct place with the correct Python 3.10.x version. make does not automatically find the target, but I think it's reasonable to just run make dev for now.

aholmes · 2024-05-14T16:18:22Z

A lot of this functionality is consistent with CAP (if not directly lifted from CAP).

Much is lifted from CAP, but has either been modified to fit into BLP or to allow more generic uses.

We may revisit feature flags in the future. The tests look good to me, but we're not yet using the feature as extensively as we likely will in the future. So far, we're focusing on storing feature flags in the database. I wonder if we might need to extend this in future to allow other methods of handling feature configuration. Way outside the scope of this PR.

Definitely. The base classes are extendable, so it should not be difficult to at least get started with this.

aholmes · 2024-05-14T16:44:34Z

Approving with Makefile updates for MacOS. make dev runs correctly for me, creating the virtual environment in the correct place with the correct Python 3.10.x version. make does not automatically find the target, but I think it's reasonable to just run make dev for now.

Cool. I still need to figure out some problem that doubled CI/CD runtimes, but I'm glad this works now.

This was caused by `PYTHON_VERSION` being, e.g., `3.10.14` while the venv directory is named `python3.10`. Some checks to determine whether to rebuild check whether a path under `.venv/lib/$PYTHON_VERSION/..` exists, and those paths never exist because the variable value is not what was expected. Instead, we now use `pip list`. This chnage required altering when the venv is activated.

…s in Makefile.

aholmes added 30 commits April 8, 2024 16:13

Add new project BL_Python.identity.

c708a80

Add SAML2 type stubs.

69e20a8

Fix some type errors in pysaml2 type stubs.

9316cd6

Add SAML2 client.

b478378

Add Identity tables to Platform lib.

b0fb457

- Also reorganized Feature Flag components to fit the structure of the Identity tables.

Update userloader to handle calling back into the application that's …

c527a44

…using it.

Fix pyright informational message.

6bdba94

Fix variable format.

c3a981e

Add flask-login dependency and type stubs.

9730134

Additional flask-login type stub updates.

4cf7bba

Make UserLoader work in Identity.

d53fdf5

Add login_required decorator.

80cb056

Rename class to avoid possible conflict.

0f297c6

Fix error in bl-alembic that suppressed exceptions from alembic.

f1e77d4

Additional classes for Identity/SSO.

7ba99eb

Fix incorrectly named foreign key ref.

0d5874d

Correct types for Identity classes.

7c74945

Move Identity DI into Platform lib.

8f17d98

Rework DI module for user loader.

277131e

Fix problem with manually-added blueprints in a Connexion app.

206da3f

- Also removed old comment.

Resolve type error and possible runtime type bug in database initiali…

2a47a6f

…zation.

Fix some type issues.

6e10231

Fix issues with types for migrations and user auth.

dfaf79d

Fix types in SSO decorator.

66b145b

Fix pyright error.

ab26ff2

Fix problems with authenticated test request context.

38e0db4

Fix type issues preventing Roles from being used without errors.

5a3562d

Make it possible to use a custom application bootstrap method with th…

9b7c499

…e openapi_client test fixture.

Refactor test client files to resolve type issues.

a8ba402

Resolve invariance error.

c7de695

aholmes added 4 commits May 2, 2024 17:46

Add SSM parameter loading to BL_Python.AWS.

1e73150

Load SSM parameters in web application startup.

5e6d109

Fix tests broken by SSM change.

b021986

Add SSM parameter loading to DB migrations.

bc70a10

aholmes requested a review from a team as a code owner May 3, 2024 23:59

aholmes assigned nwiltsie, dan-knight, yashpatel6, j2salmingo and kiarod May 3, 2024

github-advanced-security bot found potential problems May 4, 2024

View reviewed changes

src/identity/BL_Python/identity/SAML2/__init__.py Dismissed Show dismissed Hide dismissed

src/identity/BL_Python/identity/SAML2/__init__.py Dismissed Show dismissed Hide dismissed

src/identity/BL_Python/identity/SAML2/__init__.py Dismissed Show dismissed Hide dismissed

aholmes added 5 commits May 3, 2024 17:10

Be more forgiving of SSM load failures because not every app needs SSM.

d88db56

Remove old comment.

104414c

Merge branch 'main' into aholmes-identity-sso

362a9cf

Adjust Makefile to be compatible with make 3.81 for MacOS users.

44d3a39

Fix problems with venv activate and ignoring command exit statuses in…

b570bad

… Makefile.

Fix additional problems with ordering of shell commands when not usin…

a3f481d

…g `.ONESHELL`.

dan-knight previously approved these changes May 13, 2024

View reviewed changes

One more MacOS fix.

4ae20bc

aholmes dismissed dan-knight’s stale review via 4ae20bc May 13, 2024 21:27

aholmes added 3 commits May 13, 2024 15:53

Add missing dependencies to BL_Python.web.

fe005be

Fix envvar issue in Makefile.

c88f4cc

Minor CICD output changes to debug on GitHub.

89a7898

aholmes added 2 commits May 14, 2024 11:21

Further reduce build time by making use of sentinels for phony target…

36ee95a

…s in Makefile.

aholmes merged commit 11f1e95 into main May 14, 2024
12 checks passed

aholmes deleted the aholmes-identity-sso branch May 14, 2024 21:10

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

SSO, test additions, database work, ASGI middleware, and more #58

SSO, test additions, database work, ASGI middleware, and more #58

aholmes commented May 3, 2024 •

edited

Loading

dan-knight commented May 13, 2024 •

edited

Loading

dan-knight left a comment

aholmes commented May 14, 2024

aholmes commented May 14, 2024 •

edited

Loading

SSO, test additions, database work, ASGI middleware, and more #58

SSO, test additions, database work, ASGI middleware, and more #58

Conversation

aholmes commented May 3, 2024 • edited Loading

dan-knight commented May 13, 2024 • edited Loading

dan-knight left a comment

Choose a reason for hiding this comment

aholmes commented May 14, 2024

aholmes commented May 14, 2024 • edited Loading

aholmes commented May 3, 2024 •

edited

Loading

dan-knight commented May 13, 2024 •

edited

Loading

aholmes commented May 14, 2024 •

edited

Loading