-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update tool-Docker-action to v2.1.0 #21
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Something's wonky here - the image isn't building correctly in this branch or on |
Wiz Scan Summary
|
Okay @Faizal-Eeman, I think that I've got the build repaired.
Sanity-checking that, the
So does the
The $ docker run -it ghcr.io/uclahs-cds/battenberg:branch-nwiltsie_update_docker_action ls -1 /usr/local/lib/R/site-library/Battenberg
DESCRIPTION
example
extdata
help
html
INDEX
LICENSE
Meta
NAMESPACE
R
TODO
|
Yup, tested the above command and confirming Battenberg is available in |
Thanks a lot @nwiltsie. I'm merging this PR. |
This PR updates the
tool-Docker-action
Action to version 2.1.0. There are a few big changes in this version:foo
will build this repository's image and tag it asbranch-foo
. That tagged image will be removed when the branch is deleted.v1.2.3-xxx
). Repositories that need to use other kinds of tags (e.g.v1.2beta
) can pass the optionalnon-semver-tags
argument; doing so will build all tags that begin withv
.There are a bunch of smaller changes buried in there - you can see them all at this link.
Based on this repository's existing tags, I've determined that it does follow semantic versioning. The updated workflow therefore does not pass the
non-semver-tags
argument to the Action, although it can be uncommented in the future if need be.