Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to SAMTools 1.20 #17

Merged
merged 1 commit into from
Apr 18, 2024
Merged

Update to SAMTools 1.20 #17

merged 1 commit into from
Apr 18, 2024

Conversation

kiarod
Copy link
Contributor

@kiarod kiarod commented Apr 17, 2024

Description

Closes #16

Testing Results

Docker Image Testing

  • I have tested the Docker image with the docker run command as described below.

Testing version:

docker run --rm -u $(id -u):$(id -g) samtools:latest samtools --version
samtools 1.20
Using htslib 1.20
Copyright (C) 2024 Genome Research Ltd.

Test the Docker image with at least one sample. Verify the new Docker image works using:

docker run -u $(id -u):$(id -g) –w <working-directory> -v <directory-you-want-to-mount>:<how-you-want-to-mount-it-within-the-docker> --rm <docker-image-name> <command-to-the-docker-with-all-parameters>

My command:

ln -s /hot/ref/mitochondria_ref/mt_test_bams/tcga_test_file_normal.bam ./
docker run --workdir $(pwd) --rm --user $(id -u):$(id -g) --volume $(pwd):$(pwd) --volume /hot/ref/mitochondria_ref/mt_test_bams/:/hot/ref/mitochondria_ref/mt_test_bams/ samtools samtools index tcga_test_file_normal.bam

successfully creates:
tcga_test_file_normal.bam.bai

Checklist

Formatting

File Updates

  • I have ensured that the version number update follows the versioning standards.

  • I have updated the version number in the Dockerfile, README.md and metadata.yaml files.

  • I have updated the dependencies and added my name to the maintainer list in the Dockerfile.

  • I have updated the feature changes in the README.md (optional).

  • I have added the changes included in this pull request to the CHANGELOG.md under the next release version or unreleased, and updated the date.

GitHub Packages Auto Build Rules

  • I have not manually pushed this Docker image to the uclahs-cds container registry (ghcr.io/uclahs-cds) on GitHub.

  • I have updated the image_name in the metadata.yaml which is required by GitHub action to automatically build and push the image.

@kiarod kiarod requested a review from yashpatel6 April 17, 2024 21:30
Copy link
Contributor

@yashpatel6 yashpatel6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@kiarod kiarod merged commit 9a9eb12 into main Apr 18, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SAMTools v1.20
2 participants