Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting default values for heatmaps #128

Merged
merged 5 commits into from
May 16, 2024
Merged

Conversation

whelena
Copy link
Collaborator

@whelena whelena commented May 15, 2024

Description

Updating the heatmap functions to rely on the base BPG functions more for defaults while still allowing users to change parameters that might be use-case specific.

Should close 2 other (outdated) heatmap related PRs

Test Results

  • Case 1
    • input: /hot/software/package/public-R-CancerEvolutionVisualization/development/test_input/multi-sample.tsv
    • script: /hot/software/package/public-R-CancerEvolutionVisualization/development/hwinata-set-heatmap-defaults/test-plot.R
    • output: /hot/software/package/public-R-CancerEvolutionVisualization/development/hwinata-set-heatmap-defaults/.*png

Checklist

  • This PR does NOT contain Protected Health Information (PHI). A repo may need to be deleted if such data is uploaded.
    Disclosing PHI is a major problem1 - Even a small leak can be costly2.

  • This PR does NOT contain germline genetic data3, RNA-Seq, DNA methylation, microbiome or other molecular data4.

  • This PR does NOT contain other non-plain text files, such as: compressed files, images (e.g. .png, .jpeg), .pdf, .RData, .xlsx, .doc, .ppt, or other output files.

  To automatically exclude such files using a .gitignore file, see here for example.

  • I have read the code review guidelines and the code review best practice on GitHub check-list.

  • I have set up or verified the main branch protection rule following the github standards before opening this pull request.

  • The name of the branch is meaningful and well formatted following the standards, using [AD_username (or 5 letters of AD if AD is too long)]-[brief_description_of_branch].

  • I have added the major changes included in this pull request to the CHANGELOG.md under the next release version or unreleased, and updated the date.

Footnotes

  1. UCLA Health reaches $7.5m settlement over 2015 breach of 4.5m patient records

  2. The average healthcare data breach costs $2.2 million, despite the majority of breaches releasing fewer than 500 records.

  3. Genetic information is considered PHI.
    Forensic assays can identify patients with as few as 21 SNPs

  4. RNA-Seq, DNA methylation, microbiome, or other molecular data can be used to predict genotypes (PHI) and reveal a patient's identity.

@whelena whelena requested a review from dan-knight May 15, 2024 17:04
Copy link
Collaborator

@dan-knight dan-knight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'm assuming your intention for using ... is to automatically reflect changes to BPG without needing to maintain these functions in parallel. Just resolve the conflict in the changelog and we're good to go.

@whelena whelena merged commit 526131b into main May 16, 2024
6 checks passed
@whelena whelena deleted the hwinata-set-heatmap-defaults branch May 17, 2024 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants