Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Special character in filename fix #36

Merged
merged 1 commit into from
Jan 12, 2024

Conversation

yashpatel6
Copy link
Collaborator

  • I have read the code review guidelines and the code review best practice on GitHub check-list.

  • The name of the branch is meaningful and well formatted following the standards, using [AD_username (or 5 letters of AD if AD is too long)-[brief_description_of_branch].

  • I have set up or verified the branch protection rule following the github standards before opening this pull request.

  • I have added my name to the contributors listings in the
    metadata.yaml and the manifest block in the nextflow.config as part of this pull request, am listed
    already, or do not wish to be listed. (This acknowledgement is optional.)

  • I have added the changes included in this pull request to the CHANGELOG.md under the next release version or unreleased, and updated the date.

  • I have updated the version number in the metadata.yaml and manifest block of the nextflow.config file following semver, or the version number has already been updated. (Leave it unchecked if you are unsure about new version number and discuss it with the infrastructure team in this PR.)

  • I have tested the pipeline on at least one A-mini sample.

Adding fix for intermediate file deletion where filenames containing special characters results in an error during deletion.

Testing Results

Tested with convert-BAM2FASTQ, log and output here: /hot/software/pipeline/pipeline-convert-BAM2FASTQ/Nextflow/development/unreleased/yashpatel-handle-special-characters/run.log

Copy link
Member

@nwiltsie nwiltsie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look fine, although I'm curious about what triggered the issue in the first place - where did a filename with special characters come from?

@yashpatel6
Copy link
Collaborator Author

The changes look fine, although I'm curious about what triggered the issue in the first place - where did a filename with special characters come from?

There are cases where intermediate files are named based on metadata found in file headers and that results in special characters being carried into the filenames. Ex. splitting a BAM per readgroup where a readgroup ID has a special character (ID:my:id - the ID would contain :) would result in the file having that character in the name

@yashpatel6 yashpatel6 merged commit 9db08f0 into main Jan 12, 2024
1 check passed
@yashpatel6 yashpatel6 deleted the yashpatel-fix-issue-with-special-characters branch January 12, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants