2.12 (Build: 2018031100)

The log table optimisation code incorrectly included the prefix mdl_. This has now been removed.
A further optimisation to the SQL code was implemented by placing brackets around '(auf.userid = $userid OR a.markingworkflow = 0)'

README.md

@@ -29,6 +29,11 @@ The report requires jQuery to be enabled, otherwise sorting and searching will n
 
 ---
 Change log:
+
+2.12 (Build: 2018031100)
+The log table optimisation code incorrectly included the prefix mdl_. This has now been removed.
+A further optimisation to the SQL code was implemented by placing brackets around '(auf.userid = $userid OR a.markingworkflow = 0)'
+
 2.11 (Build: 2018013002)
 Added usage statistics tab to the report.
 Added a usage report permission to allow particular Moodle users access to usage statistics.

db/upgrade.php

@@ -42,16 +42,16 @@ function xmldb_report_myfeedback_upgrade($oldversion) {
         upgrade_plugin_savepoint(true, 2016031700, 'report', 'myfeedback');
     }
 	//optimise the log table
-	if ($oldversion < 2017112800) {
+	if ($oldversion < 2018031100) {
 		$table = new xmldb_table('logstore_standard_log');
 		//create index mdl_logsstanlog_usecou_ix on mdl_logstore_standard_log (userid, courseid);
-		$index = new xmldb_index('mdl_logsstanlog_usecou_ix', XMLDB_INDEX_NOTUNIQUE, array('userid', 'courseid'));
+		$index = new xmldb_index('logsstanlog_usecou_ix', XMLDB_INDEX_NOTUNIQUE, array('userid', 'courseid'));
         if (!$dbman->index_exists($table, $index)) {
             $dbman->add_index($table, $index);
         }
 
 		// Myfeedback savepoint reached.
-        upgrade_plugin_savepoint(true, 2017112800, 'report', 'myfeedback');
+        upgrade_plugin_savepoint(true, 2018031100, 'report', 'myfeedback');
     }
     return true; //have to be in else get an unknown error
-}
+}

lib.php

@@ -4594,7 +4594,7 @@ public function get_data($archive, $checkdb) {
                         LEFT JOIN {assign_grades} ag ON a.id = ag.assignment AND ag.userid=$userid ";
             if (!$archive || ($archive && $checkdb > 1314)) {//when the new assign_user_flags table came in
                 $sql .= "LEFT JOIN {assign_user_flags} auf ON a.id = auf.assignment AND auf.workflowstate = 'released'
-                        AND  auf.userid = $userid OR a.markingworkflow = 0 ";
+                        AND  (auf.userid = $userid OR a.markingworkflow = 0) ";
             }
             if (!$archive || ($archive && $checkdb > 1112)) {//when the new grading_areas table came in
                 $sql .= "LEFT JOIN {grading_areas} ga ON con.id = ga.contextid ";

version.php

@@ -32,8 +32,8 @@
  *            http://bit.ly/IoEAssessmentCareersProject
  * @license   http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
  */
-$plugin->version = 2018013002;
+$plugin->version = 2018031100;
 $plugin->component = 'report_myfeedback';
 $plugin->requires = 2013111810;
-$plugin->release = '2.11 (Build: 2018013002)';
+$plugin->release = '2.12 (Build: 2018031100)';
 $plugin->maturity = MATURITY_STABLE;