Resolve PHP errors #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When highestgrade is fetched from the database, it is returned as a string containing a float value. There is an `if ($record->highestgrade)` check before using this to calculate a grade percentage, to avoid dividing by highestgrade if it is falsy (e.g "0"). However, if it is zero, the returned string is "0.00000", which is truthy. Casting the string to a float ensures the check performs as intended.
Lots of "Error writing to database" exceptions are being reported in the shutdown function that writes event logs on this page. It's not clear why, but it's possible that its because the event are being triggered right at the end of the script, after the page output has been completed. Since the logs are buffered and written during the shutdown, there should be no performance issue triggerring the events earlier, so hopefully this is also prevent the database errors.
aspark21
approved these changes
Apr 26, 2024
|
Reviewed GHA failures, these are due to changes to moodle-cs and pre-existing behat failures in php8.2 - not related to this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.