Do not allow header length to be zero in non-zero length packet #1526
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1524
Investigating the file attached to that issue, I found that at
openjpeg/src/lib/openjp2/t2.c
Line 1354 in e8b9d92
the header length was sometimes set to zero.
It seems intuitively not good for the header length to be zero in non-zero length packet, so I suggest returning
OPJ_FALSE
for that situation.If this isn't a good solution, thanks for your time, and please let me know what I've missed.