[feature/OP-515=> QA] Intégration des FIE : partnership côdiplomation #380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
December 4, 2024 14:57
albrugnetti
reviewed
Jan 6, 2025
| # self.assertFalse(formset.is_valid()) | ||
| # self.assertIn('diploma_with_ucl_by_partner', formset.forms[0].errors) | ||
| # self.assertIn('diploma_prod_by_partner', formset.forms[0].errors) | ||
| # self.assertIn('supplement_prod_by_partner', formset.forms[0].errors) |
|
|
||
| def test_get_own_partnership_as_gs(self): | ||
| self.client.force_login(self.user_gs) | ||
| response = self.client.get(self.url, follow=True) | ||
| self.assertTemplateUsed(response, 'partnerships/partnership/partnership_update.html') | ||
| self.assertNotIn('start_academic_year', response.context_data['form_year'].fields) | ||
| # self.assertIn('start_academic_year', response.context_data['form_year'].fields) | ||
| # self.assertNotIn('start_academic_year', response.context_data['form_year'].fields) |
| self.assertNotIn('start_academic_year', response.context_data['form_year'].fields) | ||
| self.assertNotIn('is_public', response.context_data['form'].fields) | ||
| # self.assertIn('start_academic_year', response.context_data['form_year'].fields) | ||
| # self.assertNotIn('is_public', response.context_data['form'].fields) |
locale/en/LC_MESSAGES/django.po
Outdated
| msgstr "Yes" | ||
|
|
||
| msgid "Partagé" | ||
| msgstr "Shared" |
There was a problem hiding this comment.
Les messages contenu dans les balises gettext (alias '_') doivent être en Anglais et les traductions doivent être effectuées dans le fichier locale/fr/LC_MESSAGES/django.po
| window.onpopstate = function () { | ||
| window.history.pushState(null, "", window.location.href); | ||
| }; | ||
| </script> |
There was a problem hiding this comment.
Pourquoi devez-vous jouer avec l'historique du navigateur ?
| # | ||
| # form = PartnershipCourseForm(data=data, initial={"partnership_type":PartnershipType.COURSE.name}) | ||
| # print(form.errors) | ||
| # self.assertTrue(form.is_valid()) |
views/partnership/create.py
Outdated
|
|
||
| @transaction.atomic | ||
| def post(self, request, *args, **kwargs): | ||
| # self.get_partnership() |
views/partnership/create.py
Outdated
|
|
||
| return render(request, self.template_name, {'formset': formset, 'partnership': self.partnership}) | ||
|
|
||
| @transaction.atomic |
There was a problem hiding this comment.
Le décorateur n'est pas nécessaire.
Par défaut, nous optons pour les transactions atomiques au niveau d'une requête HTTP (cf. https://docs.djangoproject.com/en/5.1/ref/settings/#std-setting-DATABASE-ATOMIC_REQUESTS ). N'oubliez pas de l'activer en local dans le .env DATABASE_ATOMIC_REQUEST=True
views/partnership/read.py
Outdated
| # 'partnershiprelation', | ||
| # queryset=Organization.objects.order_by('name').select_related('partner') | ||
| # ), | ||
|
|
albrugnetti
reviewed
Jan 7, 2025
locale/en/LC_MESSAGES/django.po
Outdated
| @@ -1373,3 +1454,6 @@ msgstr "Visible on the public interface" | |||
|
|
|||
| msgid "website" | |||
| msgstr "Website" | |||
|
|
|||
| #~ msgid "diploma_by_ucl" | |||
| #~ msgstr "Diploma UCLouvain" | |||
albrugnetti
changed the title
albrugnetti
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.