Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename ToolConfigurationFacet from ToolConfigurationTypeFacet in Update tool.ttl (v2) #464

Closed
wants to merge 2 commits into from

Conversation

ajnelson-nist
Copy link
Contributor

@ajnelson-nist ajnelson-nist commented Aug 21, 2022

(Chair note: This Pull Request supersedes PR 452, which had branching issues that could not be resolved through the Github interface.)

This pull request relates to Issue #451, and the updating of the turtle file tool.ttl

Renaming of old Facet ToolConfigurationTypeFacet to ToolConfigurationFacet, which required changes to four (4) lines to within the turtle file tool.ttl.

The changes made are:

  1. Remove the text "Type" from the facet "ToolConfigurationTypeFacet", so that it becomes "ToolConfigurationFacet" (changes on lines 359, 365, 379), and
  2. Update the comment by replacing "A tool configuration type facet...." with "A tool configuration facet...." (line 366).

The change is expected to be low risk

Coordination

  • Pull Request is against correct branch
  • Pull Request is in, or reverted to, Draft status before Solutions Approval vote has passed.
  • CI passes in UCO feature branch
  • CI passes in UCO current unstable branch (merge-commit)
  • CI passes in CASE current unstable branch tracking UCO's unstable as submodule (merge-commit)
  • Impact on SHACL validation reviewed for CASE-Examples
  • Impact on SHACL validation remediated for CASE-Examples
  • Impact on SHACL validation reviewed for casework.github.io
  • Impact on SHACL validation remediated for casework.github.io
  • Milestone linked
  • Solutions Approval vote logged on corresponding Issue (once logged, can be taken out of Draft PR status)

Remove the text "Type" from the facet "ToolConfigurationTypeFacet", so that it becomes "ToolConfigurationFacet" (changes on lines 359, 365, 379), and update the comment by replacing "A tool configuration type facet...." with "A tool configuration facet...." (line 366).

(cherry picked from commit ca35281)
@ajnelson-nist
Copy link
Contributor Author

Converting to Draft until Solutions Approval vote is logged.

@gwebb-case
Copy link

Hi @ajnelson-nist, is this all in-hand, or do you want me to redo the changes and create a new pull request targeting the develop branch?
I have deleted my previous master commit as the pull request was closed, and re-forked the full UCO repository, and can now target the changes within the develop branch - but will put it on hold until you say to proceed.
To make sure I don't don't mess up this time or in the future, when committing changes should I select

  1. Commit directly to the develop branch; or
  2. Create a new branch for this commit and start a pull request.

guessing option (2) but may be wrong.

@ajnelson-nist
Copy link
Contributor Author

@gwebb-case - no further effort is needed from you on this. This had to be done with a new Pull Request because PRs are tied to the submitting branch name. But, it's done enough now, and ready for committee review.

@ajnelson-nist ajnelson-nist linked an issue Aug 29, 2022 that may be closed by this pull request
8 tasks
Copy link
Contributor

@sbarnum sbarnum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look appropriate and are limited to the proposed changes agreed to in the Requirements review approval.

@ajnelson-nist
Copy link
Contributor Author

Oh. Whoops. This PR is obviated by the concept being absorbed into the configuration namespace as part of resolving Issue 432. When I resolved the merge conflict, the whole chunk @gwebb-case modified disappeared. It migrated here.

I'm going to close the PR to avoid confusion in the Git history. Thanks for your help in any case, @gwebb-case !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename ToolConfigurationTypeFacet to ToolConfigurationFacet in tool.ttl
3 participants