Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addition of migrid init script PID file saving when not handled natively #173

Closed
wants to merge 4 commits into from

Conversation

jonasbardino
Copy link
Contributor

Adjust init script to explicitly write PID files when neither systemd nor the daemons themselves do that. Namely, support the containerized cases where init is tini or similar instead of systemd and the existing stop actions fail because they can't find a saved service PID to kill.

Needed in order to enable wider use of the migrid init script for service checks and management e.g. in checkmigssl cron job for containerized deployments and for the docker-entry.sh start up script of docker-migrid.

… nor the

daemons themselves do that. Namely, support the containerized cases where init
is tini or similar instead of systemd.
@jonasbardino jonasbardino added the enhancement New feature or request label Jan 8, 2025
@jonasbardino jonasbardino requested a review from a team January 8, 2025 14:57
@jonasbardino jonasbardino self-assigned this Jan 8, 2025
Copy link
Contributor

@Martin-Rehr Martin-Rehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@jonasbardino
Copy link
Contributor Author

Merged through svn - the flagged py2 lint failure was a ubuntu repo timeout.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants