chore(readme): moves optional agrs to own file for readability #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@raghuganapathyUCR Thanks for the PR. Can you also remove the whole section for passing the flag through a json file, will remove it from the code soon. |
nimakarimipour
requested changes
Nov 30, 2023
nimakarimipour
approved these changes
Dec 1, 2023
There was a problem hiding this comment.
@raghuganapathyUCR This is fine now, we can improve other parts as well, but let's do that in a follow up PR. Thanks.
|
@nimakarimipour I am unable to merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@nimakarimipour I moved the optional args to OPTIONS.md, only keeping the ones that are most useful to the user on the Readme. Let me know if more changes are needed.