added empty not empty operators

ucraft-com · Nov 8, 2024 · 1b16537 · 1b16537
1 parent 8e7e424
commit 1b16537
Show file tree

Hide file tree

Showing 3 changed files with 63 additions and 1 deletion.
diff --git a/src/ConditionEvaluator/ConditionEvaluator.php b/src/ConditionEvaluator/ConditionEvaluator.php
@@ -19,7 +19,7 @@ public function evaluate(array $data, array $condition): bool
     {
         // Extract condition details
         $key = $condition['key'];
-        $value = $condition['value'];
+        $value = $condition['value'] ?? null;
         $operator = $condition['operator'];
 
         // Get the actual value from the data using the Arr helper

diff --git a/src/Enums/ConditionalOperatorEnum.php b/src/Enums/ConditionalOperatorEnum.php
@@ -8,11 +8,15 @@
  * ConditionalOperatorEnum defines conditional operator types.
  * EQ - equals, the conditions on this operator must be equal.
  * NEQ - not equal, the conditions on this operator must not be equal.
+ * EMPTY - empty, the conditions on this operator must be empty.
+ * NEMPTY - not empty, the conditions on this operator must not be empty.
  */
 enum ConditionalOperatorEnum : string
 {
     case EQ = 'EQ';
     case NEQ = 'NEQ';
+    case EMPTY = 'EMPTY';
+    case NEMPTY = 'NEMPTY';
 
     /**
      * @param mixed $actualValue
@@ -25,6 +29,8 @@ public function compare(mixed $actualValue, mixed $value): bool
         return match($this) {
             self::EQ => $actualValue === $value,
             self::NEQ => $actualValue !== $value,
+            self::EMPTY => empty($actualValue),
+            self::NEMPTY => !empty($actualValue),
         };
     }
 }
diff --git a/tests/Unit/ConditionEvaluatorTest.php b/tests/Unit/ConditionEvaluatorTest.php
@@ -100,6 +100,62 @@ public function testEvaluate_WhenGivenNEQOperatorAndWrongKey_ReturnsFalse(): voi
         $this->assertFalse($result);
     }
 
+    public function testEvaluate_WhenGivenEMPTYOperatorAndValidValue_ReturnsTrue(): void
+    {
+        $data = $this->getData();
+
+        $conditions = [
+            'key'      => 'params.variantsStyles',
+            'operator' => ConditionalOperatorEnum::EMPTY->value,
+        ];
+
+        $result = $this->createInstance()->evaluate($data, $conditions);
+
+        $this->assertTrue($result);
+    }
+
+    public function testEvaluate_WhenGivenEMPTYOperatorAndNotValidValue_ReturnsFalse(): void
+    {
+        $data = $this->getData();
+
+        $conditions = [
+            'key'      => 'params.settings.name',
+            'operator' => ConditionalOperatorEnum::EMPTY->value,
+        ];
+
+        $result = $this->createInstance()->evaluate($data, $conditions);
+
+        $this->assertFalse($result);
+    }
+
+    public function testEvaluate_WhenGivenNEMPTYOperatorAndValidValue_ReturnsTrue(): void
+    {
+        $data = $this->getData();
+
+        $conditions = [
+            'key'      => 'params.settings.name',
+            'operator' => ConditionalOperatorEnum::NEMPTY->value,
+        ];
+
+        $result = $this->createInstance()->evaluate($data, $conditions);
+
+        $this->assertTrue($result);
+    }
+
+    public function testEvaluate_WhenGivenNEMPTYOperatorAndNotValidValue_ReturnsFalse(): void
+    {
+        $data = $this->getData();
+
+        $conditions = [
+            'key'      => 'params.variantsStyles',
+            'operator' => ConditionalOperatorEnum::NEMPTY->value,
+        ];
+
+        $result = $this->createInstance()->evaluate($data, $conditions);
+
+        $this->assertFalse($result);
+    }
+
     /**
      * @return array
      */