Merge pull request #3536 from yf-yang/fix-composing

fix: fix incorrect placeholder when both hideOnBlur and composing occurs
udecode · Sep 14, 2024 · 6b18ed1 · 6b18ed1
2 parents 1ba3feb + 551e310
commit 6b18ed1
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 6 deletions.
diff --git a/.changeset/twenty-cows-count.md b/.changeset/twenty-cows-count.md
@@ -0,0 +1,5 @@
+---
+'@udecode/plate-utils': patch
+---
+
+Suppress all placeholders when element is composing
diff --git a/packages/plate-utils/src/react/usePlaceholder.ts b/packages/plate-utils/src/react/usePlaceholder.ts
@@ -26,17 +26,13 @@ export const usePlaceholderState = ({
   const composing = useComposing();
   const editor = useEditorRef();
 
-  const isEmptyBlock = isElementEmpty(editor, element);
+  const isEmptyBlock = isElementEmpty(editor, element) && !composing;
 
   const enabled =
     isEmptyBlock &&
     (!query || queryNode([element, findNodePath(editor, element)!], query)) &&
     (!hideOnBlur ||
-      (isCollapsed(editor.selection) &&
-        hideOnBlur &&
-        focused &&
-        selected &&
-        !composing));
+      (isCollapsed(editor.selection) && hideOnBlur && focused && selected));
 
   return {
     enabled,