Refactor DynamicFormControlListDataProvider to a generic interface fo…

…r consistency
udos86 · Jan 17, 2020 · 2e934b1 · 2e934b1
1 parent b9fbdf3
commit 2e934b1
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/projects/ng-dynamic-forms/core/src/lib/model/misc/dynamic-form-control-data.model.ts b/projects/ng-dynamic-forms/core/src/lib/model/misc/dynamic-form-control-data.model.ts
@@ -11,8 +11,8 @@ export interface DynamicFormControlDataConfig {
   service: any;
 }
 
-export interface DynamicFormControlListDataProvider {
-  fetchList(value: string): Observable<any[]>;
+export interface DynamicFormControlListDataProvider<T> {
+  fetchList(value: string): Observable<T[]>;
 }
 
 export interface DynamicFormControlOptionDataProvider<T> {

diff --git a/projects/ng-dynamic-forms/core/src/lib/service/dynamic-form-data.service.spec.ts b/projects/ng-dynamic-forms/core/src/lib/service/dynamic-form-data.service.spec.ts
@@ -15,8 +15,8 @@ import {DynamicFormGroupModel} from '../model/form-group/dynamic-form-group.mode
 import {DynamicFormOptionConfig} from '../model/dynamic-option-control.model';
 
 @Injectable()
-class TestProvider implements DynamicFormControlListDataProvider, DynamicFormControlOptionDataProvider<string> {
-  fetchList(value: string): Observable<any[]> {
+class TestProvider implements DynamicFormControlListDataProvider<string>, DynamicFormControlOptionDataProvider<string> {
+  fetchList(value: string): Observable<string[]> {
     return of(['test']);
   }
 

diff --git a/projects/ng-dynamic-forms/core/src/lib/service/dynamic-form-data.service.ts b/projects/ng-dynamic-forms/core/src/lib/service/dynamic-form-data.service.ts
@@ -45,7 +45,7 @@ export class DynamicFormDataService {
       });
   }
 
-  isListProvider(provider: DynamicFormControlListDataProvider): boolean {
+  isListProvider(provider: DynamicFormControlListDataProvider<any>): boolean {
     return provider.fetchList !== undefined;
   }
-Original file line number
+Diff line change
@@ Expand Up / @@ -45,7 +45,7 @@ export class DynamicFormDataService { @@
           });
       }
-      isListProvider(provider: DynamicFormControlListDataProvider): boolean {
+      isListProvider(provider: DynamicFormControlListDataProvider<any>): boolean {
         return provider.fetchList !== undefined;
       }
@@ Expand Down @@