Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature OIDC logout #494

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

mdwallick
Copy link
Contributor

@mdwallick mdwallick commented Feb 7, 2022

Changes the logout behavior to use the OIDC v1/logout endpoint rather than the Okta logout URL directly. Also updates the HCL for each vertical to add post_logout_redirect_uris.


Resolves #351

@mdwallick mdwallick added the type: feature New feature or request label Feb 7, 2022
@mdwallick mdwallick linked an issue Feb 7, 2022 that may be closed by this pull request
@mdwallick
Copy link
Contributor Author

mdwallick commented Feb 24, 2022

For what it's worth, this will need to be merged for OIE orgs. The old fromURI Okta logout doesn't behave the same between classic and OIE tenants. Of course, Noi's Terraform refactor needs to be merged first so I can update this branch with my terraform changes.

@noinarisak noinarisak changed the title Feature OIDC logout iss351 Feature OIDC logout Mar 22, 2022
Copy link
Contributor

@noinarisak noinarisak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mdwallick We need to rebase or update the terraform directory structure, since that has changed.

@sonarcloud
Copy link

sonarcloud bot commented Mar 22, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Use the oidc v1/logout endpoint to logout users
2 participants