Update vue3.mdx - escaped quotation marks in code strings that causes… #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… error when copied From this: content: '<p>I'm running Tiptap with Vue.js. 🎉</p>' To this: content: '<p>I'\m running Tiptap with Vue.js. 🎉</p>'
|
@Maxxiejay is attempting to deploy a commit to the Tiptap Team on Vercel. A member of the Team first needs to authorize it. |
|
Hi Max! Thank you for taking the time to highlight and suggest a fix to the use of single quotes! :) We decided to switch to double quotes for clarity instead of escaping, so I’m closing this PR. If you’d like to discuss other improvements in detail, feel free to drop by our Discord. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… error when copied
From this:
content: '
I'm running Tiptap with Vue.js. 🎉
' To this:content: '
I'\m running Tiptap with Vue.js. 🎉
'