Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: migrate to pnpm #5978

Merged
merged 37 commits into from
Jan 6, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
37 commits
Select commit Hold shift + click to select a range
75b3836
build: switch to pnpm
nperez0111 Jan 2, 2025
d429147
build: get project building again with pnpm
nperez0111 Jan 2, 2025
f228e67
build: ci running again
nperez0111 Jan 2, 2025
b473888
build: get demos working again
nperez0111 Jan 2, 2025
172f912
chore: build all packages
nperez0111 Jan 2, 2025
fe91a39
build: get packages building again
nperez0111 Jan 2, 2025
1179c02
chore: update build
nperez0111 Jan 2, 2025
0a49431
chore: always install
nperez0111 Jan 2, 2025
53c9d58
build: set pnpm to resolve locally first
nperez0111 Jan 2, 2025
fd15347
build: get builds working
nperez0111 Jan 2, 2025
c552fe3
build: replace globby with tinyglobby
nperez0111 Jan 2, 2025
075f1e8
chore: bump setup-node version
nperez0111 Jan 2, 2025
3337055
chore: cypress tests work again
nperez0111 Jan 2, 2025
15e7251
test: specifically resolve pm packages
nperez0111 Jan 2, 2025
214aa24
build: optimize the caches
nperez0111 Jan 2, 2025
a41a7e1
build: re-enable commands tests
nperez0111 Jan 2, 2025
2234d48
build: rm logging of http reqs
nperez0111 Jan 2, 2025
a8e4a51
build: try serializing pipeline
nperez0111 Jan 2, 2025
1df3450
build: serialize
nperez0111 Jan 2, 2025
89cc3ca
build: pull from right cache
nperez0111 Jan 2, 2025
ffba16d
build: release at end
nperez0111 Jan 2, 2025
99d64c5
build: lint using turbo
nperez0111 Jan 2, 2025
61a0e38
build: use turbo to lint
nperez0111 Jan 2, 2025
4a20700
build: export types properly
nperez0111 Jan 2, 2025
b5fbedc
chore: rm dupe
nperez0111 Jan 2, 2025
ba3b9a2
build: always try to pull from same cache
nperez0111 Jan 2, 2025
c6c2b93
build: split the cache
nperez0111 Jan 2, 2025
2d0cacd
chore: use pnpm to exec
nperez0111 Jan 2, 2025
1646d1d
build: use prettier for linting
nperez0111 Nov 1, 2024
6dacc65
chore: reformat all files
nperez0111 Jan 3, 2025
598fc79
Merge branch 'next' into pnpm
nperez0111 Jan 6, 2025
24bc91d
chore: move floating-ui back to peer dep
nperez0111 Jan 6, 2025
c0eff4d
chore: rm peer dep
nperez0111 Jan 6, 2025
1c612fd
chore: export types for extension-utils properly
nperez0111 Jan 6, 2025
40b0ef0
fix: make floating-ui a dep that accepts a wide range
nperez0111 Jan 6, 2025
d9862e8
chore: rm devDep
nperez0111 Jan 6, 2025
1c999d9
chore: put back peerdep
nperez0111 Jan 6, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
2 changes: 1 addition & 1 deletion .changeset/big-wolves-design.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
---
"@tiptap/extension-placeholder": major
'@tiptap/extension-placeholder': major
---

Officially remove the `considerAnyAsEmpty` which has not been used since version 2.5
110 changes: 55 additions & 55 deletions .changeset/chilled-trees-agree.md
Original file line number Diff line number Diff line change
@@ -1,59 +1,59 @@
---
"@tiptap/extension-collaboration-cursor": major
"@tiptap/extension-code-block-lowlight": major
"@tiptap/extension-character-count": major
"@tiptap/extension-horizontal-rule": major
"@tiptap/extension-collaboration": major
"@tiptap/extension-floating-menu": major
"@tiptap/extension-ordered-list": major
"@tiptap/extension-table-header": major
"@tiptap/extension-bubble-menu": major
"@tiptap/extension-bullet-list": major
"@tiptap/extension-font-family": major
"@tiptap/extension-list-keymap": major
"@tiptap/extension-placeholder": major
"@tiptap/extension-superscript": major
"@tiptap/extension-blockquote": major
"@tiptap/extension-code-block": major
"@tiptap/extension-dropcursor": major
"@tiptap/extension-hard-break": major
"@tiptap/extension-table-cell": major
"@tiptap/extension-text-align": major
"@tiptap/extension-text-style": major
"@tiptap/extension-typography": major
"@tiptap/extension-gapcursor": major
"@tiptap/extension-highlight": major
"@tiptap/extension-list-item": major
"@tiptap/extension-paragraph": major
"@tiptap/extension-subscript": major
"@tiptap/extension-table-row": major
"@tiptap/extension-task-item": major
"@tiptap/extension-task-list": major
"@tiptap/extension-underline": major
"@tiptap/extension-document": major
"@tiptap/extension-heading": major
"@tiptap/extension-history": major
"@tiptap/extension-mention": major
"@tiptap/extension-youtube": major
"@tiptap/extension-italic": major
"@tiptap/extension-strike": major
"@tiptap/extension-color": major
"@tiptap/extension-focus": major
"@tiptap/extension-image": major
"@tiptap/extension-table": major
"@tiptap/extension-bold": major
"@tiptap/extension-code": major
"@tiptap/extension-link": major
"@tiptap/extension-text": major
"@tiptap/starter-kit": major
"@tiptap/suggestion": major
"@tiptap/react": major
"@tiptap/vue-2": major
"@tiptap/vue-3": major
"@tiptap/core": major
"@tiptap/html": major
"@tiptap/pm": major
"tiptap-demos": major
'@tiptap/extension-collaboration-cursor': major
'@tiptap/extension-code-block-lowlight': major
'@tiptap/extension-character-count': major
'@tiptap/extension-horizontal-rule': major
'@tiptap/extension-collaboration': major
'@tiptap/extension-floating-menu': major
'@tiptap/extension-ordered-list': major
'@tiptap/extension-table-header': major
'@tiptap/extension-bubble-menu': major
'@tiptap/extension-bullet-list': major
'@tiptap/extension-font-family': major
'@tiptap/extension-list-keymap': major
'@tiptap/extension-placeholder': major
'@tiptap/extension-superscript': major
'@tiptap/extension-blockquote': major
'@tiptap/extension-code-block': major
'@tiptap/extension-dropcursor': major
'@tiptap/extension-hard-break': major
'@tiptap/extension-table-cell': major
'@tiptap/extension-text-align': major
'@tiptap/extension-text-style': major
'@tiptap/extension-typography': major
'@tiptap/extension-gapcursor': major
'@tiptap/extension-highlight': major
'@tiptap/extension-list-item': major
'@tiptap/extension-paragraph': major
'@tiptap/extension-subscript': major
'@tiptap/extension-table-row': major
'@tiptap/extension-task-item': major
'@tiptap/extension-task-list': major
'@tiptap/extension-underline': major
'@tiptap/extension-document': major
'@tiptap/extension-heading': major
'@tiptap/extension-history': major
'@tiptap/extension-mention': major
'@tiptap/extension-youtube': major
'@tiptap/extension-italic': major
'@tiptap/extension-strike': major
'@tiptap/extension-color': major
'@tiptap/extension-focus': major
'@tiptap/extension-image': major
'@tiptap/extension-table': major
'@tiptap/extension-bold': major
'@tiptap/extension-code': major
'@tiptap/extension-link': major
'@tiptap/extension-text': major
'@tiptap/starter-kit': major
'@tiptap/suggestion': major
'@tiptap/react': major
'@tiptap/vue-2': major
'@tiptap/vue-3': major
'@tiptap/core': major
'@tiptap/html': major
'@tiptap/pm': major
'tiptap-demos': major
---

We are now building packages with tsup which does not support UMD builds, please repackage if you require UMD builds
2 changes: 1 addition & 1 deletion .changeset/cool-bananas-breathe.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
---
"@tiptap/core": patch
'@tiptap/core': patch
---

Remove editor.getCharacterCount() which was already deprecated and incorrectly implemented
14 changes: 7 additions & 7 deletions .changeset/dirty-bats-look.md
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
---
"@tiptap/extension-floating-menu": major
"@tiptap/extension-bubble-menu": major
"@tiptap/extension-mention": major
"@tiptap/suggestion": major
"@tiptap/react": major
"@tiptap/vue-2": major
"@tiptap/vue-3": major
'@tiptap/extension-floating-menu': major
'@tiptap/extension-bubble-menu': major
'@tiptap/extension-mention': major
'@tiptap/suggestion': major
'@tiptap/react': major
'@tiptap/vue-2': major
'@tiptap/vue-3': major
---

Removed tippy.js and replaced it with [Floating UI](https://floating-ui.com/) - a newer, more lightweight and customizable floating element library.
Expand Down
4 changes: 2 additions & 2 deletions .changeset/green-wolves-arrive.md
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
---
"@tiptap/core": major
'@tiptap/core': major
---

Fix `getPos` type in `NodeViewRendererProps` to potentially be `undefined`

Breaking change: Types may flag uses of getPos where an `undefined` possibility isn't handled.
Why this change was made: To ensure the type reflects the real functionality of this function.
How to update: Ensure that the return value of `getPos` exists before making use of the value.
How to update: Ensure that the return value of `getPos` exists before making use of the value.
2 changes: 1 addition & 1 deletion .changeset/honest-ears-trade.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
---
"@tiptap/pm": patch
'@tiptap/pm': patch
---

This fixes a problem with the release files
2 changes: 1 addition & 1 deletion .changeset/lazy-needles-train.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
---
"@tiptap/core": major
'@tiptap/core': major
---

`insertContent` and `insertContentAt` commands should not split text nodes like paragraphs into multiple nodes when the inserted content is at the beginning of the text to avoid empty nodes being created
2 changes: 1 addition & 1 deletion .changeset/perfect-rice-vanish.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
---
"@tiptap/react": minor
'@tiptap/react': minor
---

Throw an error in development mode if immediatelyRender is not set in SSR mode
2 changes: 1 addition & 1 deletion .changeset/red-rivers-exist.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
---
"@tiptap/extension-font-size": patch
'@tiptap/extension-font-size': patch
---

This adds the new @tiptap/extension-font-size extension for changing the font-size of text based on the textStyle extension
2 changes: 1 addition & 1 deletion .changeset/tame-worms-applaud.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
---
"@tiptap/core": patch
'@tiptap/core': patch
---

If a transaction results in the exact same editor state (either filtered out or failed to apply) then do not attempt to re-apply the same editor state and do not emit any events associated to the transaction
2 changes: 1 addition & 1 deletion .changeset/weak-books-eat.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
---
"@tiptap/starter-kit": major
'@tiptap/starter-kit': major
---

We have now added the Link, ListKeymap, and Underline extensions to the starter kit for a smoother onboarding experience
Expand Down
35 changes: 6 additions & 29 deletions .eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,28 +9,12 @@ module.exports = {
},
overrides: [
{
files: [
'./**/*.ts',
'./**/*.tsx',
'./**/*.js',
'./**/*.jsx',
],
files: ['./**/*.ts', './**/*.tsx', './**/*.js', './**/*.jsx'],
extends: ['plugin:react-hooks/recommended'],
},
{
files: [
'./**/*.ts',
'./**/*.tsx',
'./**/*.js',
'./**/*.jsx',
'./**/*.vue',
],
plugins: [
'html',
'cypress',
'@typescript-eslint',
'simple-import-sort',
],
files: ['./**/*.ts', './**/*.tsx', './**/*.js', './**/*.jsx', './**/*.vue'],
plugins: ['html', 'cypress', '@typescript-eslint', 'simple-import-sort'],
env: {
'cypress/globals': true,
},
Expand All @@ -43,17 +27,18 @@ module.exports = {
'plugin:@typescript-eslint/recommended',
'plugin:vue/vue3-strongly-recommended',
'airbnb-base',
'prettier',
],
rules: {
curly: ['error', 'all'],
'newline-after-var': ['error', 'always'],
'no-continue': 'off',
'no-alert': 'off',
'no-console': ['warn', { allow: ['warn', 'error'] }],
semi: ['error', 'never'],
'import/order': 'off',
'import/extensions': ['error', 'ignorePackages'],
'no-restricted-imports': ['error',
'no-restricted-imports': [
'error',
{
paths: [
{
Expand Down Expand Up @@ -81,14 +66,6 @@ module.exports = {
'vue/one-component-per-file': 'off',
'vue/this-in-template': ['error', 'never'],
'vue/multi-word-component-names': 'off',
'vue/max-attributes-per-line': ['error', {
singleline: {
max: 3,
},
multiline: {
max: 1,
},
}],
'vue/singleline-html-element-content-newline': 'off',
'no-param-reassign': 'off',
'import/prefer-default-export': 'off',
Expand Down
20 changes: 10 additions & 10 deletions .github/DISCUSSION_TEMPLATE/community-extensions.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
title: "Community Extension: "
title: 'Community Extension: '
body:
- type: markdown
attributes:
Expand All @@ -9,23 +9,23 @@ body:
attributes:
label: Description
description: Please describe how your extension works and what it does.
placeholder: "My extension does …"
placeholder: 'My extension does …'
validations:
required: true
- type: textarea
id: installation
attributes:
label: Installation
description: Please describe how users can install your extension.
placeholder: "npm install …"
placeholder: 'npm install …'
validations:
required: true
- type: textarea
id: usage
attributes:
label: Usage
description: Please describe how users can use your extension in their editor.
placeholder: "To use my extension you have to …"
placeholder: 'To use my extension you have to …'
validations:
required: true
- type: dropdown
Expand All @@ -34,18 +34,18 @@ body:
label: Type
description: Please select the type of this extension.
options:
- "Node"
- "Mark"
- "Prosemirror plugin"
- "Package or Kit"
- "Other"
- 'Node'
- 'Mark'
- 'Prosemirror plugin'
- 'Package or Kit'
- 'Other'
validations:
required: true
- type: textarea
id: other
attributes:
label: Other
description: Feel free to add any other information about your extension.
placeholder: "I hope you like …"
placeholder: 'I hope you like …'
validations:
required: false
16 changes: 8 additions & 8 deletions .github/DISCUSSION_TEMPLATE/feature-requests.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
title: "Feature Request: "
title: 'Feature Request: '
labels:
- "Type: Feature Request"
- 'Type: Feature Request'
body:
- type: markdown
attributes:
Expand All @@ -11,15 +11,15 @@ body:
attributes:
label: Description
description: Please describe the feature you would like to see in Tiptap.
placeholder: "I wish there was an extension for …"
placeholder: 'I wish there was an extension for …'
validations:
required: true
- type: textarea
id: use-case
attributes:
label: Use Case
description: Please describe the use case for this feature.
placeholder: "I want to use this feature for …"
placeholder: 'I want to use this feature for …'
validations:
required: true
- type: dropdown
Expand All @@ -28,9 +28,9 @@ body:
label: Type
description: Please select the type of this feature.
options:
- "New extension"
- "New feature"
- "New Tiptap API"
- "Other"
- 'New extension'
- 'New feature'
- 'New Tiptap API'
- 'Other'
validations:
required: true
Loading
Loading