Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): fix focus issue introduced in v2.11.0 #6043

Merged
merged 6 commits into from
Jan 22, 2025
Merged

fix(core): fix focus issue introduced in v2.11.0 #6043

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
decb222
fix focus issue introduced in v2.11.0
cpgruber Jan 21, 2025
d353968
add changeset
cpgruber Jan 21, 2025
c184709
chore: update changeset
nperez0111 Jan 22, 2025
d5b15d5
chore: update changeset
nperez0111 Jan 22, 2025
70b028a
chore: update changeset
nperez0111 Jan 22, 2025
ba50f9a
chore: please linter
nperez0111 Jan 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/thirty-deers-attend.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@tiptap/core": patch
---

Focus synchronously only if on iOS or Android #4448
8 changes: 7 additions & 1 deletion packages/core/src/commands/focus.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
import { isTextSelection } from '../helpers/isTextSelection.js'
import { resolveFocusPosition } from '../helpers/resolveFocusPosition.js'
import { FocusPosition, RawCommands } from '../types.js'
import { isAndroid } from '../utilities/isAndroid.js'
import { isiOS } from '../utilities/isiOS.js'

declare module '@tiptap/core' {
interface Commands<ReturnType> {
Expand Down Expand Up @@ -42,7 +44,11 @@ export const focus: RawCommands['focus'] = (position = null, options = {}) => ({
}

const delayedFocus = () => {
(view.dom as HTMLElement).focus()
// focus within `requestAnimationFrame` breaks focus on iOS and Android
// so we have to call this
if (isiOS() || isAndroid()) {
(view.dom as HTMLElement).focus()
}

// For React we have to focus asynchronously. Otherwise wild things happen.
// see: https://github.com/ueberdosis/tiptap/issues/1520
Expand Down
Loading