Plots enhancement #28
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ainda preciso analisar o que é ou não específico dos experimentos |
issilva5
requested changes
Aug 8, 2022
| readr::write_csv(data_with_auto_scaling, here::here(configs$output_file)) | ||
| configs <- generate_output_filepaths(configs) | ||
|
|
||
| readr::write_csv(data_with_auto_scaling, here::here(configs$policy_filepath)) |
There was a problem hiding this comment.
Acho o nome policy_filepath pouco sugestivo. Talvez simulation_filepath seja mais adequado.
| geom_text(aes(x = min(datetime), y = lower_bound-2, label = "Lower Bound"), size = 2, color = "blue") | ||
|
|
||
| } else if (startsWith(title, "Target Tracking")) { | ||
| # Draw a line for target threshold | ||
| target <- policy_parameters$target_value | ||
|
|
||
| plot <- plot + | ||
| geom_hline(yintercept = target, color = "red") + | ||
| geom_text(aes(x = 120, y = target+2, label = "Target threshold"), size = 3, color = "red") |
There was a problem hiding this comment.
Suggested change
| geom_text(aes(x = 120, y = target+2, label = "Target threshold"), size = 3, color = "red") | |
| geom_text(aes(x = min(datetime), y = target+2, label = "Target threshold"), size = 3, color = "red") |
Comment on lines
+36
to
46
| geom_text(aes(x = min(datetime),y = upper_bound+2, label = "Upper Bound"), size = 2, color = "red") + | ||
| geom_hline(yintercept = lower_bound, color = "blue") + | ||
| geom_text(aes(x = 70, y = lower_bound-2, label = "Lower Bound"), size = 3, color = "blue") | ||
|
|
||
| } else if (policy_name == "target_tracking") { | ||
| geom_text(aes(x = min(datetime), y = lower_bound-2, label = "Lower Bound"), size = 2, color = "blue") | ||
|
|
||
| } else if (startsWith(title, "Target Tracking")) { | ||
| # Draw a line for target threshold | ||
| target <- policy_parameters$target_value | ||
|
|
||
| plot <- plot + | ||
| geom_hline(yintercept = target, color = "red") + | ||
| geom_text(aes(x = 120, y = target+2, label = "Target threshold"), size = 3, color = "red") |
There was a problem hiding this comment.
Ao invés de no y colocar valor + constante, dá uma olhada no parâmetro nudge_y, ele faz esse tipo de deslocamento.
| labs(y = "Cores", x = "Tempo (min)") | ||
| labs(y = "Cores", x = "Time (hour)", color = "") + | ||
| theme(legend.position = "top", legend.direction = "horizontal") + | ||
| scale_x_datetime(date_breaks = date_break, date_labels = "%H:%M") |
There was a problem hiding this comment.
Eu adicionaria aqui linhas horizontais com a quantidade mínima e máxima de cores.
| # Creates two plots for cores and system utilization over time comparing | ||
| # real and simulation results. | ||
| title <- get_title(data, configs$policies$use) | ||
| date_break <- get_plot_date_break(configs) |
There was a problem hiding this comment.
Suggested change
| date_break <- get_plot_date_break(configs) | |
| date_break <- ifelse(is.null(configs$plot_scale_datetime), "1 hour", configs$plot_scale_datetime) |
Acho meio desnecessário criar uma função que faz apenas um if...else.
Comment on lines
+84
to
92
| get_plot_date_break <- function(configs) { | ||
| if (is.null(configs$plot_scale_datetime)) { | ||
| date_break <- "1 hour" | ||
| } else { | ||
| date_break <- configs$plot_scale_datetime | ||
| } | ||
|
|
||
| return (date_break) | ||
| } |
There was a problem hiding this comment.
Suggested change
| get_plot_date_break <- function(configs) { | |
| if (is.null(configs$plot_scale_datetime)) { | |
| date_break <- "1 hour" | |
| } else { | |
| date_break <- configs$plot_scale_datetime | |
| } | |
| return (date_break) | |
| } |
|
|
||
| # Generate output base filepath | ||
| output_basename <- str_split(basename(configs$input_file), '[.]')[[1]][1] | ||
| output_base_filepath <- paste(configs$output_directory, output_basename, sep='') |
There was a problem hiding this comment.
Pelo que entendi isso constrói um path, então o ideal é utilizar file.path, porque ai não depende do usuário colocar o separador correto.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.